Bug 87196 - [Chromium-Android] Fix chromium_android_unittest
Summary: [Chromium-Android] Fix chromium_android_unittest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks: 86862
  Show dependency tree / graph
 
Reported: 2012-05-22 19:08 PDT by Xianzhu Wang
Modified: 2012-05-23 14:13 PDT (History)
7 users (show)

See Also:

Attachments
patch (9.04 KB, patch)
2012-05-23 12:34 PDT, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
patch v2 (9.04 KB, patch)
2012-05-23 12:38 PDT, Xianzhu Wang 		tony: review+
tony: commit-queue-
Details | Formatted Diff | Diff
patch v3 (9.43 KB, patch)
2012-05-23 13:28 PDT, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-05-22 19:08:41 PDT 
chromium_android_unittest is broken by http://trac.webkit.org/changeset/118089. Will disable the test first and then fix it.
Sorry for the breakage.
Comment 1 Xianzhu Wang 2012-05-22 19:21:14 PDT 
Temporarily disable chromium_android_unittest: http://trac.webkit.org/changeset/118100
Comment 2 Xianzhu Wang 2012-05-23 12:34:24 PDT 
Created attachment 143618 [details]
patch
Comment 3 Xianzhu Wang 2012-05-23 12:38:46 PDT 
Created attachment 143622 [details]
patch v2
Comment 4 Tony Chang 2012-05-23 13:10:15 PDT 
Comment on attachment 143622 [details]
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=143622&action=review

> Tools/ChangeLog:16
> +        * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
> +        (ChromiumAndroidPortTest):
> +        (ChromiumAndroidPortTest.mock_run_command_fn):
> +        (ChromiumAndroidPortTest.test_get_last_stacktrace):
> +        (ChromiumAndroidPortTest.test_get_crash_log):
> +        (ChromiumAndroidDriverTest):
> +        (ChromiumAndroidDriverTest.setUp):
> +        (ChromiumAndroidDriverTest.test_cmd_line):
> +        (ChromiumAndroidDriverTest.test_write_command_and_read_line):

Please describe your changes here.
Comment 5 Xianzhu Wang 2012-05-23 13:28:31 PDT 
Created attachment 143634 [details]
patch v3
Comment 6 Xianzhu Wang 2012-05-23 13:28:52 PDT 
Comment on attachment 143622 [details]
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=143622&action=review

>> Tools/ChangeLog:16
>> +        (ChromiumAndroidDriverTest.test_write_command_and_read_line):
> 
> Please describe your changes here.

Done.
Comment 7 WebKit Review Bot 2012-05-23 14:13:08 PDT 
Comment on attachment 143634 [details]
patch v3

Clearing flags on attachment: 143634

Committed r118244: <http://trac.webkit.org/changeset/118244>
Comment 8 WebKit Review Bot 2012-05-23 14:13:14 PDT 
All reviewed patches have been landed.  Closing bug.