Bug 86862 - [Chromium-Android] Run DumpRenderTree as an apk
Summary: [Chromium-Android] Run DumpRenderTree as an apk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on: 86922 86923 87196
Blocks: 66687
  Show dependency tree / graph
 
Reported: 2012-05-18 09:26 PDT by Xianzhu Wang
Modified: 2012-05-23 14:15 PDT (History)
8 users (show)

See Also:

Attachments
patch (63.79 KB, patch)
2012-05-18 15:38 PDT, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
patch v2 (63.79 KB, patch)
2012-05-18 15:50 PDT, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-05-18 09:26:24 PDT 
On Android, some features (e.g. media player) are implemented through Java API, so DumpRenderTree need to provide a Java environment so that the tests depending on those features can pass.
Comment 1 Xianzhu Wang 2012-05-18 15:38:59 PDT 
Created attachment 142797 [details]
patch
Comment 2 WebKit Review Bot 2012-05-18 15:42:23 PDT 
Attachment 142797 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/D..." exit_code: 1
Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xianzhu Wang 2012-05-18 15:50:17 PDT 
Created attachment 142806 [details]
patch v2
Comment 4 Tony Chang 2012-05-18 16:12:39 PDT 
This patch is gigantic.  Can we split off the C++ & gyp changes from the python changes?  Can the python changes be split into multiple patches?
Comment 5 Xianzhu Wang 2012-05-18 16:40:11 PDT 
(In reply to comment #4)
> This patch is gigantic.  Can we split off the C++ & gyp changes from the python changes?  Can the python changes be split into multiple patches?

I'll split it into two parts (bug 86922 and bug 86923). It's difficult to split the python part.