That is poorly named and should follow its families.
Created attachment 144301 [details] Patch
Comment on attachment 144301 [details] Patch OK
Comment on attachment 144301 [details] Patch This naming in the client does not seem good. We want boolean functions to finish phrases like this "client <xxx>". The phrases "client allow image" and "client allow shadow DOM" are not grammatical. Adding the letter "s" might be sufficient to make these follow the guideline: "allows shadow DOM". When did these names get into WebKit? Did I just overlook it?
Comment on attachment 144301 [details] Patch Rejecting attachment 144301 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: nabledFeatures.cpp patching file Source/WebCore/loader/FrameLoaderClient.h patching file Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp patching file Source/WebKit/chromium/src/FrameLoaderClientImpl.h Hunk #1 FAILED at 199. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/FrameLoaderClientImpl.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12849124
Created attachment 144409 [details] Patch for landing
Comment on attachment 144409 [details] Patch for landing Clearing flags on attachment: 144409 Committed r118714: <http://trac.webkit.org/changeset/118714>
All reviewed patches have been landed. Closing bug.