Bug 87063 – <shadow> and <content> should be hidden behind ContextEnabledFeatures

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

Currently they are hidden by RuntimeEnabledFeatures. But it could be fine-tunable to make Bug 86895 possible.

[Hajime Morrita]

Created attachment 143214 [details]
Patch

[Hajime Morrita]

Hi Dimitri, could you take a look? This one is an obvious part of this series.

[Hajime Morrita]

Created attachment 143240 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 143240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143240&action=review

> Source/WebCore/ChangeLog:6
> +        This change repalced "runtimeConditional" tag definition property

repalced -> replaces.

> Source/WebCore/ChangeLog:8
> +        ContextEnabledFeatures instead of RuntimeEnabledFeatures.

But why are we replacing this? Should not both of these co-exist?

> Source/WebCore/ChangeLog:9
> +        This also introduce ContextEnabledFeatures::shadowDOMEnabled(Document*)

introduce -> introduces.

> Source/WebCore/ChangeLog:10
> +        for a complement.

"as a complement". But why do we need both?

[Hajime Morrita]

Hi Dimitri, Thanks for reviewing!
I'll land the updated patch shortly.

> 
> > Source/WebCore/ChangeLog:8
> > +        ContextEnabledFeatures instead of RuntimeEnabledFeatures.
> 
> But why are we replacing this? Should not both of these co-exist?
They could. But I don't think they should. If we need both, make_names.pl should get refactored
before that.

> > Source/WebCore/ChangeLog:10
> > +        for a complement.
> 
> "as a complement". But why do we need both?
Good question.
My feeling was that it's strage for the parser to know about domWindow.
But it might be overkill. I'll try to get rid of this.

[Hajime Morrita]

Created attachment 143402 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 143402 [details]
Patch for landing

Clearing flags on attachment: 143402

Committed r118098: <http://trac.webkit.org/changeset/118098>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.