Bug 87063 - <shadow> and <content> should be hidden behind ContextEnabledFeatures
Summary: <shadow> and <content> should be hidden behind ContextEnabledFeatures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on: 86555
Blocks: 86895 86984 87101
  Show dependency treegraph
 
Reported: 2012-05-21 18:16 PDT by Hajime Morrita
Modified: 2012-05-22 19:02 PDT (History)
6 users (show)

See Also:


Attachments
Patch (7.58 KB, patch)
2012-05-22 00:40 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (7.58 KB, patch)
2012-05-22 02:25 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch for landing (5.46 KB, patch)
2012-05-22 17:06 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-05-21 18:16:14 PDT
Currently they are hidden by RuntimeEnabledFeatures. But it could be fine-tunable to make Bug 86895 possible.
Comment 1 Hajime Morrita 2012-05-22 00:40:36 PDT
Created attachment 143214 [details]
Patch
Comment 2 Hajime Morrita 2012-05-22 00:42:14 PDT
Hi Dimitri, could you take a look? This one is an obvious part of this series.
Comment 3 Hajime Morrita 2012-05-22 02:25:13 PDT
Created attachment 143240 [details]
Patch
Comment 4 Dimitri Glazkov (Google) 2012-05-22 09:20:57 PDT
Comment on attachment 143240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143240&action=review

> Source/WebCore/ChangeLog:6
> +        This change repalced "runtimeConditional" tag definition property

repalced -> replaces.

> Source/WebCore/ChangeLog:8
> +        ContextEnabledFeatures instead of RuntimeEnabledFeatures.

But why are we replacing this? Should not both of these co-exist?

> Source/WebCore/ChangeLog:9
> +        This also introduce ContextEnabledFeatures::shadowDOMEnabled(Document*)

introduce -> introduces.

> Source/WebCore/ChangeLog:10
> +        for a complement.

"as a complement". But why do we need both?
Comment 5 Hajime Morrita 2012-05-22 16:52:20 PDT
Hi Dimitri, Thanks for reviewing!
I'll land the updated patch shortly.

> 
> > Source/WebCore/ChangeLog:8
> > +        ContextEnabledFeatures instead of RuntimeEnabledFeatures.
> 
> But why are we replacing this? Should not both of these co-exist?
They could. But I don't think they should. If we need both, make_names.pl should get refactored
before that.

> > Source/WebCore/ChangeLog:10
> > +        for a complement.
> 
> "as a complement". But why do we need both?
Good question.
My feeling was that it's strage for the parser to know about domWindow.
But it might be overkill. I'll try to get rid of this.
Comment 6 Hajime Morrita 2012-05-22 17:06:41 PDT
Created attachment 143402 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-05-22 19:02:25 PDT
Comment on attachment 143402 [details]
Patch for landing

Clearing flags on attachment: 143402

Committed r118098: <http://trac.webkit.org/changeset/118098>
Comment 8 WebKit Review Bot 2012-05-22 19:02:30 PDT
All reviewed patches have been landed.  Closing bug.