Enable webaudio/ tests on DRT/Mac.
In order to support most of the WebAudio layout tests, DRT needs to implement setAudioData (as opposed to setEncodedAudioData).
Created attachment 144914 [details] Patch
Attachment 144914 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h:61: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/bindings/objc/DOMPrivate.h:101: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 144914 [details] Patch Attachment 144914 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12814008
Created attachment 144917 [details] Patch Add setAudioData() stub implementations to all the port-specific LayoutTestControllers.
Attachment 144917 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebCore/bindings/objc/DOMPrivate.h:101: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h:61: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 144920 [details] Patch Fixed reverse #if logic in Source/WebCore/html/canvas/ArrayBufferView.idl
Attachment 144920 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebCore/bindings/objc/DOMPrivate.h:101: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h:61: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 144920 [details] Patch Attachment 144920 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12843947
Comment on attachment 144920 [details] Patch Attachment 144920 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12846950
Created attachment 144931 [details] Patch Made the new LayoutTestController::audioData() functions unconditional.
Attachment 144931 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebCore/bindings/objc/DOMPrivate.h:101: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h:61: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
See also bug 67187
Created attachment 146125 [details] Patch
This last patch has been much simplified. It should be very easy for other ports to implement setAudioData() by copying the implementation in LayoutTestControllerMac.mm and by adding a DumpRenderTree<Port>::jsToArrayBufferView() function in the WebCoreTestSupport.
Created attachment 146134 [details] Patch This time with the correct files included...
Attachment 146134 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebKit/mac/WebCoreSupport/DumpRenderTreeSupportMac.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 146134 [details] Patch Attachment 146134 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12909088
Created attachment 146400 [details] Patch Made the JSArrayBufferView.h header private, which fixes the compile error in WebKit.
Attachment 146400 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebKit/mac/WebCoreSupport/DumpRenderTreeSupportMac.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 146400 [details] Patch This patch looks good to me but I'd prefer to let another reviewer more experienced with the Mac port to r+
Comment on attachment 146400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146400&action=review >> Source/WebKit/mac/WebCoreSupport/DumpRenderTreeSupportMac.cpp:26 >> +#include "DumpRenderTreeSupportMac.h" > > Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] DumpRenderTreeSupport is a terrible name for this, a) because DumpRenderTree itself is a terrible name, and b) because presumably this would also be used from WebKitTestRunner. Why can't this be done via window.internals?
Comment on attachment 146400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146400&action=review >>> Source/WebKit/mac/WebCoreSupport/DumpRenderTreeSupportMac.cpp:26 >>> +#include "DumpRenderTreeSupportMac.h" >> >> Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] > > DumpRenderTreeSupport is a terrible name for this, a) because DumpRenderTree itself is a terrible name, and b) because presumably this would also be used from WebKitTestRunner. > > Why can't this be done via window.internals? DumpRenderTreeSupport already exists in the tree; it is where all the other ports put this kind of thing. Moving this into window.internals would require rewriting all the tests, instead of just fixing the existing ones. Maybe we should do that, but not in this bug.
Jer, do you plan to update this patch soon?
I have this working - it's quite a bit different now, with typed arrays having moved to JSC. But there are several failures when running in WK1 that I'd like to investigate.
Created attachment 214646 [details] patch to run by EWS Oh, it's because we have misplaced expected results (someone put them to platform/mac-wk2 instead of platform/mac). The attached patch works, but it includes changes from bug 123057 to make sure things compile, and lacks ChangeLogs.
Created attachment 214647 [details] patch to run by EWS Forgot LayoutTest changes.
Created attachment 214655 [details] patch to run by EWS Unsure why it failed to apply. Anyway, I just moved the expected results in place in r157670 manually, so uploading a patch without any binaries.
Comment on attachment 214655 [details] patch to run by EWS Attachment 214655 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6658019
Comment on attachment 214655 [details] patch to run by EWS Attachment 214655 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/5368067
Comment on attachment 214655 [details] patch to run by EWS Mac EWS is stuck crashing because of bug 123066.
Created attachment 214680 [details] proposed patch
Comment on attachment 214680 [details] proposed patch Attachment 214680 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6338010
Comment on attachment 214680 [details] proposed patch Attachment 214680 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6308009
Comment on attachment 214680 [details] proposed patch Attachment 214680 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6468030
Created attachment 214682 [details] proposed patch With gtk/efl build fix (Mac should be fixed by r157687).
Comment on attachment 214682 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=214682&action=review > Tools/DumpRenderTree/TestRunner.cpp:341 > + JSC::JSArrayBufferView* jsBufferView = JSC::jsDynamicCast<JSC::JSArrayBufferView*>(toJS(toJS(context), arguments[0])); Maybe bufferViewWrapper would be a better name for this local variable? > Tools/DumpRenderTree/TestRunner.cpp:344 > + const char* buffer = (const char*)bufferView->baseAddress(); Why a C-style cast? Can we use static_cast or const_cast or reinterpret_cast?
Committed <http://trac.webkit.org/r157691>. > Maybe bufferViewWrapper would be a better name for this local variable? Not sure, I like the one with prefix more, and I think that it's common style in bindings code. > Why a C-style cast? Can we use static_cast or const_cast or reinterpret_cast? Changed to static_cast.
*** Bug 185471 has been marked as a duplicate of this bug. ***