Bug 123066 - Mac DumpRenderTree builds without NDEBUG even in release mode
Summary: Mac DumpRenderTree builds without NDEBUG even in release mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Major
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 86914
  Show dependency tree / graph
 
Reported: 2013-10-19 12:45 PDT by Alexey Proskuryakov
Modified: 2013-10-19 16:17 PDT (History)
2 users (show)

See Also:

Attachments
proposed fix (1.87 KB, patch)
2013-10-19 12:53 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
proposed fix (2.47 KB, patch)
2013-10-19 14:50 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-19 12:45:31 PDT 
Crazy.

I noticed this when I tried to use RefPtr with an ArrayBufferView passed from a test - since that was created in NDEBUG code, the object lacked these variables, and assertions were off:

#if CHECK_REF_COUNTED_LIFECYCLE
    bool m_deletionHasBegun;
    bool m_adoptionIsRequired;
    ThreadRestrictionVerifier m_verifier;
#endif
Comment 1 Alexey Proskuryakov 2013-10-19 12:53:25 PDT 
Created attachment 214661 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2013-10-19 14:50:30 PDT 
Created attachment 214674 [details]
proposed fix

Dan found that this was incorrect - it fixed release builds, but added NDEBUG to debugs ones too.

Changed to more closely follow what other projects do.
Comment 3 WebKit Commit Bot 2013-10-19 16:16:59 PDT 
Comment on attachment 214674 [details]
proposed fix

Clearing flags on attachment: 214674

Committed r157686: <http://trac.webkit.org/changeset/157686>
Comment 4 WebKit Commit Bot 2013-10-19 16:17:01 PDT 
All reviewed patches have been landed.  Closing bug.