Bug 86782 - Refactor LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html
Summary: Refactor LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSiz...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joe Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-17 15:25 PDT by Joe Thomas
Modified: 2012-05-18 09:41 PDT (History)
4 users (show)

See Also:


Attachments
ProposedPatch (17.54 KB, patch)
2012-05-17 16:13 PDT, Joe Thomas
tony: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (17.54 KB, patch)
2012-05-17 17:59 PDT, Joe Thomas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Thomas 2012-05-17 15:25:27 PDT
Refactor the testcase to include round-trip testing.

Relevant discussion: https://bugs.webkit.org/show_bug.cgi?id=86739#c3
Comment 1 Joe Thomas 2012-05-17 16:13:53 PDT
Created attachment 142582 [details]
ProposedPatch
Comment 2 WebKit Review Bot 2012-05-17 17:50:00 PDT
Comment on attachment 142582 [details]
ProposedPatch

Rejecting attachment 142582 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/12728065
Comment 3 Joe Thomas 2012-05-17 17:59:44 PDT
Created attachment 142598 [details]
Patch

Re-posting the patch as the previous patch got rejected by the commit-queue.
Comment 4 WebKit Review Bot 2012-05-18 09:41:34 PDT
Comment on attachment 142598 [details]
Patch

Clearing flags on attachment: 142598

Committed r117603: <http://trac.webkit.org/changeset/117603>
Comment 5 WebKit Review Bot 2012-05-18 09:41:44 PDT
All reviewed patches have been landed.  Closing bug.