Bug 86736 – Frame flattening should not expand tiny frames

• Status: RESOLVED
• Resolution: FIXED
• Component: Frames

[Antti Koivisto]

If a frame has so small fixed size that it is not usefully scrollable on desktop it is probably not mean to be scrolled. We shouldn't expand frames like that.

[Antti Koivisto]

<rdar://problem/11326104>

[Antti Koivisto]

Created attachment 142477 [details]
patch

[Kenneth Rohde Christiansen]

Comment on attachment 142477 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142477&action=review

> Source/WebCore/ChangeLog:10
> +        If a frame has so small fixed size that it is not usefully scrollable on desktop it is probably
> +        not meant to be scrolled. Displaying any otherwise invisible content by expanding the frame
> +        may end up looking like a rendering error.

Shouldnt we then disable actual scrolling of it?

[Antti Koivisto]

(In reply to comment #3)
> Shouldnt we then disable actual scrolling of it?

We probably don't want to alter the non-flattened behavior if that's what you mean. Web developers are allowed to do stupid things. We just want to prevent flattening displaying garbage that is not easily visible otherwise.

[Antti Koivisto]

http://trac.webkit.org/changeset/117451

[Eric Seidel (no email)]

Comment on attachment 142477 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142477&action=review

> LayoutTests/fast/frames/flattening/iframe-tiny.html:40
> +<iframe id="testFrame0" width="0px" height="0px" style="border-width:0px" scrolling=auto src="data:text/html,

There are nicer ways besides copy/paste :)  Also srcdoc= is the new hotness.

[alan]

follow up bug#86770 to reshuffle flattening checking logic.