RESOLVED INVALID 86770
Move logic of checking whether a frame needs to be flattened to RenderFrameBase.
https://bugs.webkit.org/show_bug.cgi?id=86770
Summary Move logic of checking whether a frame needs to be flattened to RenderFrameBase.
alan baradlay
Reported 2012-05-17 13:08:37 PDT
So that flattening checking code can somewhat be shared between frameset and iframe. That would eliminate the need of early return and mimicking non-flattening layout case in RenderFrameBase::layoutWithFlattening(), which can get (and is) out of sync in case of iframe layouting. See below. RenderFrameBase::layoutWithFlattening(...) { ... if (!width() || !height() || !childRoot) { updateWidgetPosition(); if (childFrameView) childFrameView->layout(); setNeedsLayout(false); return; ... } vs. RenderIFrame::layout() { ... RenderPart::layout(); m_overflow.clear(); addVisualEffectOverflow(); updateLayerTransform(); setNeedsLayout(false); ... }
Attachments
Ahmad Saleem
Comment 1 2025-07-01 14:54:04 PDT
https://github.com/WebKit/WebKit/commit/37224f042c178a094cc2287dee595345bc89f687 <- Frame Flattening code is gone, should we close this? @Alan
Note You need to log in before you can comment on or make changes to this bug.