appcache tests were recently unskipped in Bug 85585 but a lot of them appear to be flaky on the EFL debug build bot.
Created attachment 142249 [details] Patch
Comment on attachment 142249 [details] Patch Looks good.
Comment on attachment 142249 [details] Patch Looks make sense.
Comment on attachment 142249 [details] Patch Clearing flags on attachment: 142249 Committed r117382: <http://trac.webkit.org/changeset/117382>
All reviewed patches have been landed. Closing bug.
DRT crashes on the test startup with this patch. The EFL Debug Buildbot is red exiting early after 20 crashes and 0 timeouts. 7188 tests run. http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/1874/steps/layout-test/logs/stdio Here is the backtrace of the crash: Program terminated with signal 11, Segmentation fault. #0 0x00007f1784e586e9 in WebCore::ApplicationCacheStorage::setCacheDirectory (this=0x227ef50, cacheDirectory="/tmp/DumpRenderTree-DwQlJv/Applications") at /WebKit/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:366 366 ASSERT(m_cacheDirectory.isNull()); (gdb) bt #0 0x00007f1784e586e9 in WebCore::ApplicationCacheStorage::setCacheDirectory (this=0x227ef50, cacheDirectory="/tmp/DumpRenderTree-DwQlJv/Applications") at /WebKit/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:366 #1 0x00007f1781d818c6 in ewk_settings_application_cache_path_set (path=0x7fff8797f9c0 "/tmp/DumpRenderTree-DwQlJv/Applications") at /WebKit/Source/WebKit/efl/ewk/ewk_settings.cpp:306 #2 0x0000000000464068 in DumpRenderTreeChrome::initialize (this=0x2291cb0) at /WebKit/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:163 #3 0x00000000004638a3 in DumpRenderTreeChrome::create (evas=0x228b230) at /WebKit/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:58 #4 0x0000000000461cb9 in main (argc=2, argv=0x7fff87980388) at /WebKit/Tools/DumpRenderTree/efl/DumpRenderTree.cpp:402 (gdb)
Ok, I'll make a debug build to reproduce. Feel free to roll out the patch in the mean time.
Reopening. Gyuyoung rolled out r117382 manually in <http://trac.webkit.org/changeset/117425> and did not reopen this bug.
Created attachment 142546 [details] Patch No longer set the app cache path in ewk_main since the path can only be set once and this prevents DRT to override it. Update the ewk_settings documentation to clarify this and indicate the default value change.
Comment on attachment 142546 [details] Patch Looks good to me, thank you.
Comment on attachment 142546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142546&action=review > Source/WebKit/efl/ewk/ewk_main.cpp:-170 > - ewk_settings_application_cache_path_set(webkitDirectory.utf8().data()); You should remove the brackets here.
Created attachment 142552 [details] Patch Fix minor style issue. Thanks Thiago.
LGTM. Thanks. BTW, I think we should apply the idea of this patch to other "default paths". IMO it is intrusive to set something by default to ~/.webkit/.
Comment on attachment 142552 [details] Patch Clearing flags on attachment: 142552 Committed r117552: <http://trac.webkit.org/changeset/117552>