Bug 85585 - [EFL] EFL's LayoutTestController does not implement setApplicationCacheOriginQuota
Summary: [EFL] EFL's LayoutTestController does not implement setApplicationCacheOrigin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 86195 86498
  Show dependency treegraph
 
Reported: 2012-05-04 00:03 PDT by Chris Dumez
Modified: 2012-05-16 06:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (14.81 KB, patch)
2012-05-04 00:17 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (15.02 KB, patch)
2012-05-06 22:40 PDT, Chris Dumez
gustavo: review+
gustavo: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (14.89 KB, patch)
2012-05-15 22:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch for landing (15.11 KB, patch)
2012-05-15 22:47 PDT, Chris Dumez
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (15.13 KB, patch)
2012-05-16 02:35 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-05-04 00:03:12 PDT
EFL's LayoutTestController needs to implement setApplicationCacheOriginQuota so that test cases in http/tests/appcache can be unskipped.
Comment 1 Chris Dumez 2012-05-04 00:17:43 PDT
Created attachment 140170 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-06 12:02:02 PDT
Comment on attachment 140170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140170&action=review

> Source/WebKit/efl/ewk/ewk_view.h:177
> +    uint64_t (*exceeded_application_cache_quota)(Ewk_View_Smart_Data *sd, Ewk_Security_Origin* origin, int64_t defaultOriginQuota, int64_t totalSpaceNeeded);

Whenever you change this struct, you need to bump EWK_VIEW_SMART_CLASS_VERSION.
Comment 3 Chris Dumez 2012-05-06 22:40:16 PDT
Created attachment 140479 [details]
Patch

Bump EWK_VIEW_SMART_CLASS_VERSION.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-08 08:13:34 PDT
Comment on attachment 140479 [details]
Patch

Looks good.
Comment 5 Gustavo Noronha (kov) 2012-05-15 11:21:05 PDT
Comment on attachment 140479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140479&action=review

I'm setting cq- because of the nit.

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:127
> +        // Rounding up or down not really matter for these tests. It's

Nit: not really -> does not really
Comment 6 Chris Dumez 2012-05-15 22:38:09 PDT
Created attachment 142149 [details]
Patch for landing
Comment 7 Chris Dumez 2012-05-15 22:47:45 PDT
Created attachment 142153 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-05-16 01:28:07 PDT
Comment on attachment 142153 [details]
Patch for landing

Rejecting attachment 142153 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12706609
Comment 9 Chris Dumez 2012-05-16 02:35:17 PDT
Created attachment 142207 [details]
Patch for landing

Forgot to update reviewer name in Changelogs.
Comment 10 WebKit Review Bot 2012-05-16 04:26:05 PDT
Comment on attachment 142207 [details]
Patch for landing

Clearing flags on attachment: 142207

Committed r117258: <http://trac.webkit.org/changeset/117258>
Comment 11 WebKit Review Bot 2012-05-16 04:26:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Thiago Marcos P. Santos 2012-05-16 06:05:38 PDT
This patch caused a regression. See bug 86611.