EFL's LayoutTestController needs to implement setApplicationCacheOriginQuota so that test cases in http/tests/appcache can be unskipped.
Created attachment 140170 [details] Patch
Comment on attachment 140170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140170&action=review > Source/WebKit/efl/ewk/ewk_view.h:177 > + uint64_t (*exceeded_application_cache_quota)(Ewk_View_Smart_Data *sd, Ewk_Security_Origin* origin, int64_t defaultOriginQuota, int64_t totalSpaceNeeded); Whenever you change this struct, you need to bump EWK_VIEW_SMART_CLASS_VERSION.
Created attachment 140479 [details] Patch Bump EWK_VIEW_SMART_CLASS_VERSION.
Comment on attachment 140479 [details] Patch Looks good.
Comment on attachment 140479 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140479&action=review I'm setting cq- because of the nit. > Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:127 > + // Rounding up or down not really matter for these tests. It's Nit: not really -> does not really
Created attachment 142149 [details] Patch for landing
Created attachment 142153 [details] Patch for landing
Comment on attachment 142153 [details] Patch for landing Rejecting attachment 142153 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12706609
Created attachment 142207 [details] Patch for landing Forgot to update reviewer name in Changelogs.
Comment on attachment 142207 [details] Patch for landing Clearing flags on attachment: 142207 Committed r117258: <http://trac.webkit.org/changeset/117258>
All reviewed patches have been landed. Closing bug.
This patch caused a regression. See bug 86611.