Bug 86541 – Add didFinishProgress BundleUIClient callback

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Dinu Jacob]

Add didFinishProgress BundleUIClient callback for WebKitTestRunner.

[Dinu Jacob]

Created attachment 142092 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 142092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142092&action=review

> Source/WebKit2/WebProcess/qt/QtBuiltinBundlePage.cpp:77
> +        0 // didFinishProgress

indentation is inconsistent with above lines

[Dinu Jacob]

Created attachment 142237 [details]
Patch with indentation fix

[WebKit Review Bot]

Comment on attachment 142237 [details]
Patch with indentation fix

Clearing flags on attachment: 142237

Committed r117276: <http://trac.webkit.org/changeset/117276>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

Is it safe to add to this client interface without bumping the version number?

[Brady Eidson]

(In reply to comment #6)
> Is it safe to add to this client interface without bumping the version number?

No, it was not safe to add to this client interface without bumping the version number.  This broke WebKit nightlies, for example.

[Brady Eidson]

(In reply to comment #7)
> (In reply to comment #6)
> > Is it safe to add to this client interface without bumping the version number?
> 
> No, it was not safe to add to this client interface without bumping the version number.  This broke WebKit nightlies, for example.

Apologies - I thought this was on a version 0 client.  It was on a version 1 client. We're good!

[Dinu Jacob]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Is it safe to add to this client interface without bumping the version number?
> > 
> > No, it was not safe to add to this client interface without bumping the version number.  This broke WebKit nightlies, for example.
> 
> Apologies - I thought this was on a version 0 client.  It was on a version 1 client. We're good!

Thanks!

[Brady Eidson]

I have a deeper question about this, though.

This change unskipped a qt-wk2 test only...  Was this truly QT-WK2 specific?

On the surface it seems like if this callback was truly important for this test, then no WK2 port could have passed without this callback.

What am I missing?

[Brady Eidson]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Is it safe to add to this client interface without bumping the version number?
> > 
> > No, it was not safe to add to this client interface without bumping the version number.  This broke WebKit nightlies, for example.
> 
> Apologies - I thought this was on a version 0 client.  It was on a version 1 client. We're good!

FWIW, we got confused about which client was changing because the bug and Change/Commit Log said BundleUIClient, but it was actually the BundleLoaderClient  :)

[Dinu Jacob]

(In reply to comment #11)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (In reply to comment #6)
> > > > Is it safe to add to this client interface without bumping the version number?
> > > 
> > > No, it was not safe to add to this client interface without bumping the version number.  This broke WebKit nightlies, for example.
> > 
> > Apologies - I thought this was on a version 0 client.  It was on a version 1 client. We're good!
> 
> FWIW, we got confused about which client was changing because the bug and Change/Commit Log said BundleUIClient, but it was actually the BundleLoaderClient  :)

Sorry about that. I realized it also now :(

[Dinu Jacob]

(In reply to comment #10)
> I have a deeper question about this, though.
> 
> This change unskipped a qt-wk2 test only...  Was this truly QT-WK2 specific?
> 
> On the surface it seems like if this callback was truly important for this test, then no WK2 port could have passed without this callback.
> 
> What am I missing?


I meant to check in other wk2 skipped lists too. But forgot about it before submitting my patch. I see it in mac-wk2 and gitk-wk2 lists as well.

[Brady Eidson]

Bumped the client anyway in https://bugs.webkit.org/show_bug.cgi?id=86638