Bug 86541 - Add didFinishProgress BundleUIClient callback
Summary: Add didFinishProgress BundleUIClient callback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-15 16:05 PDT by Dinu Jacob
Modified: 2012-05-16 09:45 PDT (History)
6 users (show)

See Also:


Attachments
Patch (15.85 KB, patch)
2012-05-15 16:19 PDT, Dinu Jacob
kenneth: review+
Details | Formatted Diff | Diff
Patch with indentation fix (15.88 KB, patch)
2012-05-16 06:11 PDT, Dinu Jacob
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dinu Jacob 2012-05-15 16:05:25 PDT
Add didFinishProgress BundleUIClient callback for WebKitTestRunner.
Comment 1 Dinu Jacob 2012-05-15 16:19:23 PDT
Created attachment 142092 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-05-16 00:21:36 PDT
Comment on attachment 142092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142092&action=review

> Source/WebKit2/WebProcess/qt/QtBuiltinBundlePage.cpp:77
> +        0 // didFinishProgress

indentation is inconsistent with above lines
Comment 3 Dinu Jacob 2012-05-16 06:11:48 PDT
Created attachment 142237 [details]
Patch with indentation fix
Comment 4 WebKit Review Bot 2012-05-16 06:46:55 PDT
Comment on attachment 142237 [details]
Patch with indentation fix

Clearing flags on attachment: 142237

Committed r117276: <http://trac.webkit.org/changeset/117276>
Comment 5 WebKit Review Bot 2012-05-16 06:47:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 mitz 2012-05-16 07:27:59 PDT
Is it safe to add to this client interface without bumping the version number?
Comment 7 Brady Eidson 2012-05-16 08:35:47 PDT
(In reply to comment #6)
> Is it safe to add to this client interface without bumping the version number?

No, it was not safe to add to this client interface without bumping the version number.  This broke WebKit nightlies, for example.
Comment 8 Brady Eidson 2012-05-16 08:40:20 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > Is it safe to add to this client interface without bumping the version number?
> 
> No, it was not safe to add to this client interface without bumping the version number.  This broke WebKit nightlies, for example.

Apologies - I thought this was on a version 0 client.  It was on a version 1 client. We're good!
Comment 9 Dinu Jacob 2012-05-16 08:41:38 PDT
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Is it safe to add to this client interface without bumping the version number?
> > 
> > No, it was not safe to add to this client interface without bumping the version number.  This broke WebKit nightlies, for example.
> 
> Apologies - I thought this was on a version 0 client.  It was on a version 1 client. We're good!

Thanks!
Comment 10 Brady Eidson 2012-05-16 08:51:32 PDT
I have a deeper question about this, though.

This change unskipped a qt-wk2 test only...  Was this truly QT-WK2 specific?

On the surface it seems like if this callback was truly important for this test, then no WK2 port could have passed without this callback.

What am I missing?
Comment 11 Brady Eidson 2012-05-16 08:58:11 PDT
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Is it safe to add to this client interface without bumping the version number?
> > 
> > No, it was not safe to add to this client interface without bumping the version number.  This broke WebKit nightlies, for example.
> 
> Apologies - I thought this was on a version 0 client.  It was on a version 1 client. We're good!

FWIW, we got confused about which client was changing because the bug and Change/Commit Log said BundleUIClient, but it was actually the BundleLoaderClient  :)
Comment 12 Dinu Jacob 2012-05-16 08:59:37 PDT
(In reply to comment #11)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (In reply to comment #6)
> > > > Is it safe to add to this client interface without bumping the version number?
> > > 
> > > No, it was not safe to add to this client interface without bumping the version number.  This broke WebKit nightlies, for example.
> > 
> > Apologies - I thought this was on a version 0 client.  It was on a version 1 client. We're good!
> 
> FWIW, we got confused about which client was changing because the bug and Change/Commit Log said BundleUIClient, but it was actually the BundleLoaderClient  :)

Sorry about that. I realized it also now :(
Comment 13 Dinu Jacob 2012-05-16 09:00:17 PDT
(In reply to comment #10)
> I have a deeper question about this, though.
> 
> This change unskipped a qt-wk2 test only...  Was this truly QT-WK2 specific?
> 
> On the surface it seems like if this callback was truly important for this test, then no WK2 port could have passed without this callback.
> 
> What am I missing?


I meant to check in other wk2 skipped lists too. But forgot about it before submitting my patch. I see it in mac-wk2 and gitk-wk2 lists as well.
Comment 14 Brady Eidson 2012-05-16 09:45:24 PDT
Bumped the client anyway in https://bugs.webkit.org/show_bug.cgi?id=86638