Bug 86638 - Bump the version number on the WKBundlePageLoaderClient
Summary: Bump the version number on the WKBundlePageLoaderClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-16 08:54 PDT by Brady Eidson
Modified: 2012-05-16 10:27 PDT (History)
3 users (show)

See Also:


Attachments
Patch v1 (1.87 KB, patch)
2012-05-16 08:56 PDT, Brady Eidson
mitz: review-
Details | Formatted Diff | Diff
Patch v2 - Now with more traits (2.47 KB, patch)
2012-05-16 09:03 PDT, Brady Eidson
mitz: review+
gustavo: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-05-16 08:54:00 PDT
Bump the version number on the WKBundlePageLoaderClient
Comment 1 Brady Eidson 2012-05-16 08:56:30 PDT
Created attachment 142273 [details]
Patch v1
Comment 2 Brady Eidson 2012-05-16 08:59:41 PDT
Working on the traits, also.
Comment 3 Brady Eidson 2012-05-16 09:03:31 PDT
Created attachment 142276 [details]
Patch v2 - Now with more traits

Still waiting on my build to catch up, won't land before that.
Comment 4 Gustavo Noronha (kov) 2012-05-16 09:10:02 PDT
Comment on attachment 142276 [details]
Patch v2 - Now with more traits

Attachment 142276 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12708584
Comment 5 Build Bot 2012-05-16 09:10:43 PDT
Comment on attachment 142276 [details]
Patch v2 - Now with more traits

Attachment 142276 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12723049
Comment 6 Build Bot 2012-05-16 09:19:15 PDT
Comment on attachment 142276 [details]
Patch v2 - Now with more traits

Attachment 142276 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12716297
Comment 7 Brady Eidson 2012-05-16 09:30:37 PDT
http://trac.webkit.org/changeset/117301
Comment 8 Brady Eidson 2012-05-16 09:30:59 PDT
The EWS failures were things I picked up locally and resolved before landing.  Sorry for the noise.
Comment 9 Dinu Jacob 2012-05-16 09:49:34 PDT
Is there a general guideline on when the version should be bumped up when a new callback is added?
Comment 10 Brady Eidson 2012-05-16 10:27:27 PDT
(In reply to comment #9)
> Is there a general guideline on when the version should be bumped up when a new callback is added?

Not in cases like this one. The folks impacted in this case are trying to come up with a better process going forward.