Bug 86449 - Rename Node::shadowTreeRootNode() to Node::shadowRoot()
Summary: Rename Node::shadowTreeRootNode() to Node::shadowRoot()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on: 86428
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-15 00:03 PDT by Shinya Kawanaka
Modified: 2012-05-15 20:06 PDT (History)
5 users (show)

See Also:


Attachments
Patch (15.42 KB, patch)
2012-05-15 01:37 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (15.01 KB, patch)
2012-05-15 19:29 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (15.33 KB, patch)
2012-05-15 19:43 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-05-15 00:03:12 PDT
In the discussion for Bug 86428, we concluded that we should rename Node::shadowTreeRootNode() to shadowRoot().
Comment 1 Shinya Kawanaka 2012-05-15 01:37:04 PDT
Created attachment 141891 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-15 18:43:14 PDT
Comment on attachment 141891 [details]
Patch

Rejecting attachment 141891 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
g rejects to file Source/WebCore/html/shadow/HTMLContentElement.cpp.rej
patching file Source/WebCore/html/shadow/InsertionPoint.cpp
patching file Source/WebCore/page/EventHandler.cpp
patching file Source/WebCore/svg/SVGElement.cpp
patching file Source/WebKit/chromium/src/WebFrameImpl.cpp
Hunk #1 succeeded at 1784 (offset 18 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Darin Adler']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12709261
Comment 3 Shinya Kawanaka 2012-05-15 19:29:15 PDT
Created attachment 142130 [details]
Patch for landing
Comment 4 Shinya Kawanaka 2012-05-15 19:43:55 PDT
Created attachment 142132 [details]
Patch for landing
Comment 5 Shinya Kawanaka 2012-05-15 20:06:33 PDT
Committed r117210: <http://trac.webkit.org/changeset/117210>