RESOLVED FIXED86428
Node::shadowTreeRootNode() should return ShadowRoot instead of Node. 
https://bugs.webkit.org/show_bug.cgi?id=86428
Summary Node::shadowTreeRootNode() should return ShadowRoot instead of Node.
Shinya Kawanaka
Reported 2012-05-14 19:08:05 PDT
It definitely returns only ShadowRoot. Then the return type should be ShadowRoot.
Attachments
Patch (10.42 KB, patch)
2012-05-14 19:44 PDT, Shinya Kawanaka 		morrita: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-05-14 19:44:35 PDT
Created attachment 141844 [details] Patch
Shinya Kawanaka
Comment 2 2012-05-14 20:57:25 PDT
maybe OK to build. I'll reuse the same patch for review.
Hajime Morrita
Comment 3 2012-05-14 23:02:14 PDT
Comment on attachment 141844 [details] Patch How about to just call it shadowRoot()?
Shinya Kawanaka
Comment 4 2012-05-14 23:42:28 PDT
(In reply to comment #3) > (From update of attachment 141844 [details]) > How about to just call it shadowRoot()? OK. I'll update the patch soon.
Shinya Kawanaka
Comment 5 2012-05-14 23:58:34 PDT
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 141844 [details] [details]) > > How about to just call it shadowRoot()? > > OK. I'll update the patch soon. Ah, I found that it is easy to fix the name after Bug 86341 is landed. Let rename later...
Hajime Morrita
Comment 6 2012-05-14 23:59:43 PDT
Comment on attachment 141844 [details] Patch rs=me
Shinya Kawanaka
Comment 7 2012-05-15 00:11:20 PDT
Committed r117036: <http://trac.webkit.org/changeset/117036>
Note You need to log in before you can comment on or make changes to this bug.