WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
86252
[chromium] Remove unused code for tap target fuzzing
https://bugs.webkit.org/show_bug.cgi?id=86252
Summary
[chromium] Remove unused code for tap target fuzzing
Terry Anderson
Reported
2012-05-11 14:13:58 PDT
Once
https://bugs.webkit.org/show_bug.cgi?id=85101
lands, there will be some unnecessary code I had previously landed for tap target fuzzing that can be removed:
https://bugs.webkit.org/show_bug.cgi?id=84053
- WebGestureEvent will no longer need to store gammaX and gammaY. Now we will only need the touch center along with deltaX and deltaY (which represent the touch radii). These values define a rectangular touch region having width 2*deltaX and height 2*deltaY.
https://bugs.webkit.org/show_bug.cgi?id=85296
- Originally I had planned on passing in a pre-targeted node to EventHandler::handleGestureTap. But instead, WK85101 allows chromium to use the existing touch_adjustment code to determine the best target given a rectangular touch region.
Attachments
Patch
(9.51 KB, patch)
2012-05-11 14:32 PDT
,
Terry Anderson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Terry Anderson
Comment 1
2012-05-11 14:32:11 PDT
Created
attachment 141498
[details]
Patch
WebKit Review Bot
Comment 2
2012-05-11 14:35:30 PDT
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
WebKit Review Bot
Comment 3
2012-05-15 11:06:55 PDT
Comment on
attachment 141498
[details]
Patch Clearing flags on attachment: 141498 Committed
r117098
: <
http://trac.webkit.org/changeset/117098
>
WebKit Review Bot
Comment 4
2012-05-15 11:07:00 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug