Bug 86252 - [chromium] Remove unused code for tap target fuzzing
: [chromium] Remove unused code for tap target fuzzing
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 83947
  Show dependency treegraph
 
Reported: 2012-05-11 14:13 PST by
Modified: 2012-05-15 11:07 PST (History)


Attachments
Patch (9.51 KB, patch)
2012-05-11 14:32 PST, Terry Anderson
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-05-11 14:13:58 PST
Once https://bugs.webkit.org/show_bug.cgi?id=85101 lands, there will be some unnecessary code I had previously landed for tap target fuzzing that can be removed:

https://bugs.webkit.org/show_bug.cgi?id=84053 - WebGestureEvent will no longer need to store gammaX and gammaY. Now we will only need the touch center along with deltaX and deltaY (which represent the touch radii). These values define a rectangular touch region having width 2*deltaX and height 2*deltaY.

https://bugs.webkit.org/show_bug.cgi?id=85296 - Originally I had planned on passing in a pre-targeted node to EventHandler::handleGestureTap. But instead, WK85101 allows chromium to use the existing touch_adjustment code to determine the best target given a rectangular touch region.
------- Comment #1 From 2012-05-11 14:32:11 PST -------
Created an attachment (id=141498) [details]
Patch
------- Comment #2 From 2012-05-11 14:35:30 PST -------
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
------- Comment #3 From 2012-05-15 11:06:55 PST -------
(From update of attachment 141498 [details])
Clearing flags on attachment: 141498

Committed r117098: <http://trac.webkit.org/changeset/117098>
------- Comment #4 From 2012-05-15 11:07:00 PST -------
All reviewed patches have been landed.  Closing bug.