Bug 84053 – [chromium] Allow WebGestureEvent to store four floating point values

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Terry Anderson]

A first step to implementing master bug https://bugs.webkit.org/show_bug.cgi?id=83947. Currently a WebGestureEvent stores two floats (deltaX and deltaY) which are unused in Tap and Press events. This patch will add gammaX and gammaY members to WebGestureEvent so that (deltaX, deltaY) and (gammaX, gammaY) can be used to represent the top left and bottom right coordinates of the enclosing rectangle of the ellipse information associated with the touch event.

[Terry Anderson]

Created attachment 137382 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Attachment 137382 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Fisher (:fishd, Google)]

Comment on attachment 137382 [details]
Patch

CQ- due to style error

[Terry Anderson]

Created attachment 137390 [details]
Patch

[Terry Anderson]

Created attachment 137393 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 137393 [details]
Patch for landing

Clearing flags on attachment: 137393

Committed r114301: <http://trac.webkit.org/changeset/114301>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.