Bug 86121 - [Chromium] Remove WEBKIT_USING_SKIA ifdefs that are always true
Summary: [Chromium] Remove WEBKIT_USING_SKIA ifdefs that are always true
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
Depends on:
Reported: 2012-05-10 11:32 PDT by Mark Pilgrim (Google)
Modified: 2012-05-10 14:43 PDT (History)
6 users (show)

See Also:

Patch (12.93 KB, patch)
2012-05-10 12:18 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-10 11:32:58 PDT
As discussed in https://bugs.webkit.org/show_bug.cgi?id=86018#c9
Comment 1 James Robinson 2012-05-10 11:36:31 PDT
Equivalent chromium patch is here: https://chromiumcodereview.appspot.com/10391041/

once that lands it should be possible to remove the WEBKIT_USING_SKIA definition from WebCommon.h
Comment 2 Mark Pilgrim (Google) 2012-05-10 12:18:59 PDT
Created attachment 141222 [details]
Comment 3 Mark Pilgrim (Google) 2012-05-10 12:19:37 PDT
This patch does not touch WebCommon.h.
Comment 4 WebKit Review Bot 2012-05-10 12:20:19 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 Adam Barth 2012-05-10 13:02:24 PDT
Comment 6 WebKit Review Bot 2012-05-10 14:43:20 PDT
Comment on attachment 141222 [details]

Clearing flags on attachment: 141222

Committed r116689: <http://trac.webkit.org/changeset/116689>
Comment 7 WebKit Review Bot 2012-05-10 14:43:25 PDT
All reviewed patches have been landed.  Closing bug.