Bug 86018 - [Chromium] Remove dead code behind unused WEBKIT_USING_CG
Summary: [Chromium] Remove dead code behind unused WEBKIT_USING_CG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-09 14:40 PDT by Mark Pilgrim (Google)
Modified: 2012-05-10 11:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.84 KB, patch)
2012-05-10 06:22 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-09 14:40:06 PDT 
As discussed in https://bugs.webkit.org/show_bug.cgi?id=85758#c12
Comment 1 James Robinson 2012-05-09 14:53:54 PDT 
Note that WEBKIT_USING_CG and WEBKIT_USING_SKIA are defined in WebCommon.h.  I don't think we can delete those yet, since they're used in chromium code, but I'm working on removing those on the chromium side.
Comment 2 Adam Barth 2012-05-09 14:57:25 PDT 
To be clear: we can delete the code behind the WEBKIT_USING_CG ifdef, but we can't delete the definition of the ifdef in WebCommon.h yet?
Comment 3 James Robinson 2012-05-09 15:07:03 PDT 
Right.
Comment 4 James Robinson 2012-05-09 15:19:38 PDT 
After https://chromiumcodereview.appspot.com/10392018/ lands and rolls, it should be safe to delete the definition of WEBKIT_USING_CG completely. I'll do a follow-on that removes the need to define WEBKIT_USING_SKIA
Comment 5 Mark Pilgrim (Google) 2012-05-10 06:22:01 PDT 
Created attachment 141158 [details]
Patch
Comment 6 Mark Pilgrim (Google) 2012-05-10 06:23:18 PDT 
Removes all dead code behind WEBKIT_USING_CG. Does not touch WebCommon.h.
Comment 7 WebKit Review Bot 2012-05-10 06:24:45 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 8 Eric Seidel (no email) 2012-05-10 10:20:39 PDT 
Comment on attachment 141158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141158&action=review

> Source/WebKit/chromium/README:42
>    WEBKIT_USING_JSC is defined when using JSC as the JavaScript library.

Seems this one could also be retired. :)
Comment 9 Adam Barth 2012-05-10 11:08:56 PDT 
Comment on attachment 141158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141158&action=review

> Source/Platform/chromium/public/WebImage.h:36
>  #if WEBKIT_USING_SKIA

I wonder if we can remove all these ifdefs too since this should now always be true.
Comment 10 WebKit Review Bot 2012-05-10 11:27:14 PDT 
Comment on attachment 141158 [details]
Patch

Clearing flags on attachment: 141158

Committed r116666: <http://trac.webkit.org/changeset/116666>
Comment 11 WebKit Review Bot 2012-05-10 11:27:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Mark Pilgrim (Google) 2012-05-10 11:33:24 PDT 
Filed bug 86121 for WEBKIT_USING_SKIA.