Bug 86101 - [EFL] DRT needs an implementation of layoutTestController.setSerializeHTTPLoads
Summary: [EFL] DRT needs an implementation of layoutTestController.setSerializeHTTPLoads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
: 86476 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-05-10 08:05 PDT by Sudarsana Nagineni (babu)
Modified: 2012-05-18 01:15 PDT (History)
5 users (show)

See Also:


Attachments
patch (9.76 KB, patch)
2012-05-10 09:44 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff
Patch (9.94 KB, patch)
2012-05-14 05:15 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff
Patch (9.98 KB, patch)
2012-05-16 07:32 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-05-10 08:05:53 PDT
Implement layoutTestController.setSerializeHTTPLoads in order to unskip the following tests.
fast/preloader/document-write-2.html
fast/preloader/document-write.html
http/tests/local/link-stylesheet-load-order-preload.html
fast/loader/file-protocol-fragment.html
Comment 1 Sudarsana Nagineni (babu) 2012-05-10 09:44:49 PDT
Created attachment 141185 [details]
patch

Add setSerializeHTTPLoads implementation.
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-13 15:14:12 PDT
Comment on attachment 141185 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141185&action=review

Makes sense, I guess.

> LayoutTests/ChangeLog:13
> +        * platform/efl/fast/loader/file-protocol-fragment-expected.txt: Removed.

Can you explain why this file has been removed? Do we match the base expectation now?
Comment 3 Sudarsana Nagineni (babu) 2012-05-14 05:13:36 PDT
Comment on attachment 141185 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141185&action=review

>> LayoutTests/ChangeLog:13
>> +        * platform/efl/fast/loader/file-protocol-fragment-expected.txt: Removed.
> 
> Can you explain why this file has been removed? Do we match the base expectation now?

Thanks for your review! 
Yes, the current result matches the base expectation, so I removed the platform-specific results.
Comment 4 Sudarsana Nagineni (babu) 2012-05-14 05:15:24 PDT
Created attachment 141699 [details]
Patch

Update changelog.
Comment 5 Mikhail Pozdnyakov 2012-05-15 06:45:01 PDT
*** Bug 86476 has been marked as a duplicate of this bug. ***
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-05-15 13:25:35 PDT
Comment on attachment 141699 [details]
Patch

Looks fine, thanks for the patch.
Comment 7 Gyuyoung Kim 2012-05-15 18:55:52 PDT
Comment on attachment 141699 [details]
Patch

Looks fine.
Comment 8 Sudarsana Nagineni (babu) 2012-05-16 07:32:50 PDT
Created attachment 142255 [details]
Patch

rebased
Comment 9 WebKit Review Bot 2012-05-18 01:15:14 PDT
Comment on attachment 142255 [details]
Patch

Clearing flags on attachment: 142255

Committed r117561: <http://trac.webkit.org/changeset/117561>
Comment 10 WebKit Review Bot 2012-05-18 01:15:18 PDT
All reviewed patches have been landed.  Closing bug.