RESOLVED INVALID 86086
[Qt][WK2] REGRESSION(r116560): It made 7 compositing tests fail 
https://bugs.webkit.org/show_bug.cgi?id=86086
Summary [Qt][WK2] REGRESSION(r116560): It made 7 compositing tests fail
Csaba Osztrogonác
Reported 2012-05-10 04:20:40 PDT
Before http://trac.webkit.org/changeset/116560 compositing tests pass on Qt5-WK2 platform. But this change modified only the expected files without any source change. So after this change the tests started to fail on Qt: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r116562%20%282497%29/results.html I don't know anything about these tests, numbers in the expected files don't say for me anything, I have no idea which one is the correct. And I can't compare png results, because they are set to dumpastext, and generating pixel result for dumpastext tests is impossible.
Attachments
Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-05-10 04:26:09 PDT
I skipped them - http://trac.webkit.org/changeset/116628
Noam Rosenthal
Comment 2 2012-05-10 06:07:07 PDT
Thanks, it's ok to skip those for now, I'll take a look.
Adrienne Walker
Comment 3 2012-05-10 08:45:20 PDT
(In reply to comment #0) > But this change modified only the expected files without any source change. You're right that there was no source change, but I modified the tests and then updated the expectations to match those test changes. If it helps, I suspect that it was the addition of margin:0 and the removal of overflow:hidden that moved things around in your text expectations.
Note You need to log in before you can comment on or make changes to this bug.