[whopper:~/dev/webkit/wip] $ webkit-patch upload Total errors found: 0 in 2 files Please enter a bug number or a title for a new bug: WebPageProxy::activeURL() should return the pending API request, even when there's no main frame Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue... Logging in as vestbo@webkit.org... Creating bug with title "WebPageProxy::activeURL() should return the pending API request, even when there's no main frame" Bug 85806 created. https://bugs.webkit.org/show_bug.cgi?id=85806 Running status to find changed, added, or removed files. Reviewing diff to determine which lines changed. Traceback (most recent call last): File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkit-patch", line 69, in <module> main() File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkit-patch", line 64, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 74, in run self._tool.executive.run_and_throw_if_fail(args, self._options.quiet, cwd=self._tool.scm().checkout_root) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/common/system/executive.py", line 140, in run_and_throw_if_fail exit_code = self._run_command_with_teed_output(args, child_stdout, **kwargs) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/common/system/executive.py", line 125, in _run_command_with_teed_output teed_output.write(output_line) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/common/system/deprecated_logging.py", line 55, in write file.write(bytes) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 351, in write data, consumed = self.encode(object, self.errors) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 31: ordinal not in range(128) webkit-patch upload 3.04s user 0.81s system 6% cpu 57.152 total [whopper:~/dev/webkit/wip] $ git diff diff --git i/Source/WebKit2/ChangeLog w/Source/WebKit2/ChangeLog index 1f27c0a..95167be 100644 --- i/Source/WebKit2/ChangeLog +++ w/Source/WebKit2/ChangeLog @@ -1,3 +1,12 @@ +2012-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + WebPageProxy::activeURL() should return the pending API request, even when there's no main frame + https://bugs.webkit.org/show_bug.cgi?id=85806 + + Reviewed by NOBODY (OOPS!). + + * UIProcess/WebPageProxy.cpp: + 2012-05-07 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r116299, r116301, and r116303.
Running "webkit-patch post" with the resulting working directory diff works fine.
Created attachment 141738 [details] Patch
Seems reasonable to me. Dirk?
Comment on attachment 141738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141738&action=review Seems plausible. > w/Tools/Scripts/webkit-patch:57 > + # wrong, and the stacktrace should show you were we Typo: "where", not "were".
Committed r117049: <http://trac.webkit.org/changeset/117049>