Bug 85806 - WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
Summary: WebPageProxy::activeURL() should return the pending API request, even when th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tor Arne Vestbø
URL:
Keywords:
Depends on:
Blocks: 77554
  Show dependency tree / graph
 
Reported: 2012-05-07 10:23 PDT by Tor Arne Vestbø
Modified: 2012-05-10 10:14 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.99 KB, patch)
2012-05-07 10:32 PDT, Tor Arne Vestbø 		no flags Details | Formatted Diff | Diff
Patch (4.94 KB, patch)
2012-05-09 03:02 PDT, Tor Arne Vestbø 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tor Arne Vestbø 2012-05-07 10:23:53 PDT 
WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
Comment 1 Tor Arne Vestbø 2012-05-07 10:32:35 PDT 
Created attachment 140546 [details]
Patch
Comment 2 Darin Adler 2012-05-08 13:15:13 PDT 
Comment on attachment 140546 [details]
Patch

Sure would be nice to say why this is a good change. The bug title and change log states that this should be done and says nothing about why.
Comment 3 Tor Arne Vestbø 2012-05-09 03:02:28 PDT 
Created attachment 140897 [details]
Patch
Comment 4 Tor Arne Vestbø 2012-05-09 03:04:43 PDT 
(In reply to comment #2)
> (From update of attachment 140546 [details])
> Sure would be nice to say why this is a good change. The bug title and change log states that this should be done and says nothing about why.

Sorry about that, was having some issues with webkit-patch and failed to fill in the changelog. New patch uploaded.
Comment 5 Simon Hausmann 2012-05-10 03:35:55 PDT 
Comment on attachment 140897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140897&action=review

> Source/WebKit2/ChangeLog:8
> +        immedeatly from activeURL, even if the request has not been passed over to

immedeatly -> immediately
Comment 6 Tor Arne Vestbø 2012-05-10 10:14:00 PDT 
Landed with fleshed out changelog in r116626