Bug 85627 - Tie lifetime of SVGAnimateElement::m_animatedType to the duration of the animation
Summary: Tie lifetime of SVGAnimateElement::m_animatedType to the duration of the anim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 41761
  Show dependency tree / graph
 
Reported: 2012-05-04 08:13 PDT by Nikolas Zimmermann
Modified: 2012-05-08 12:43 PDT (History)
1 user (show)

See Also:

Attachments
Patch (38.19 KB, patch)
2012-05-04 08:20 PDT, Nikolas Zimmermann 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2012-05-04 08:13:49 PDT 
Tie lifetime of SVGAnimateElement::m_animatedType to the duration of the animation.
For non-frozen animations, we still keep the animVal around and just reset it to the base val.
For CSS property animations we never remove a property if we animated it via SMIL, but only change it back to the base value.

This makes integration with CSS Animations/Transitions hard, and needs to be changed both for CSS & XML animations.
Unfortunately that requires a precise knowledge of which animation is contributing to an animated value at any point in time. Patch upcoming.
Comment 1 Nikolas Zimmermann 2012-05-04 08:20:01 PDT 
Created attachment 140236 [details]
Patch
Comment 2 Antti Koivisto 2012-05-08 11:53:18 PDT 
Comment on attachment 140236 [details]
Patch

r=me
Comment 3 Nikolas Zimmermann 2012-05-08 12:43:43 PDT 
Committed r116451: <http://trac.webkit.org/changeset/116451>