Bug 85620 – [EFL] Page caching permission from EFL's FrameLoaderClient

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Mikhail Pozdnyakov]

EFL's FrameLoaderClient should allow page caching in order to fix 
fast/events/pagehide-xhr-open.html 
fast/loader/window-properties-restored-from-page-cache.html
and unskip
fast/events/pageshow-pagehide-on-back-cached.html
(and maybe others)

[Mikhail Pozdnyakov]

Created attachment 140385 [details]
fix

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 140385 [details]
fix

Do you know what commit should have flipped this flag?

[Mikhail Pozdnyakov]

(In reply to comment #2)
> (From update of attachment 140385 [details])
> Do you know what commit should have flipped this flag?

e9ecc747

[phone]  Leandro Pereira  <[e-mail]>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Add EFL port files to efl/WebCoreSupport.
+        http://webkit.org/b/35915
+
+        * efl/WebCoreSupport/FrameLoaderClientEfl.cpp: Added.
+        * efl/WebCoreSupport/FrameLoaderClientEfl.h: Added.

[Raphael Kubo da Costa (:rakuco)]

Weird, I remember some page cache-related bugs being sent afterwards, so I thought the missing bits were implemented later. Looks fine, I guess.

[Gustavo Noronha (kov)]

Comment on attachment 140385 [details]
fix

We also added a setting to our WebKitGTK+ API, do you (plan to )have something of the sort for EFL?

[WebKit Review Bot]

Comment on attachment 140385 [details]
fix

Clearing flags on attachment: 140385

Committed r116341: <http://trac.webkit.org/changeset/116341>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Mikhail Pozdnyakov]

(In reply to comment #5)
> (From update of attachment 140385 [details])
> We also added a setting to our WebKitGTK+ API, do you (plan to )have something of the sort for EFL?

In EFL we have it in ewk_view:

EAPI Eina_Bool    ewk_view_setting_page_cache_get(const Evas_Object *o);
EAPI Eina_Bool    ewk_view_setting_page_cache_set(Evas_Object *o, Eina_Bool enable);

[Thiago Marcos P. Santos]

I might be wrong, but this patch is causing this test here to crash:
fast/frames/frame-crash-with-page-cache.html

[Thiago Marcos P. Santos]

(In reply to comment #9)
> I might be wrong, but this patch is causing this test here to crash:
> fast/frames/frame-crash-with-page-cache.html

Yes, it is. I rolled out the patch locally and it doesn't crash. I'm gonna open a bug for that.