Bug 35915 – [EFL] Add FrameLoaderClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Leandro Pereira]

+++ This bug was initially created as a clone of Bug #35059 +++

Attached patch adds EFL's implementation of FrameLoaderClient to
WebKit/efl/WebCoreSupport.

[Leandro Pereira]

Created attachment 50298 [details]
Add FrameLoaderClientEfl to WK/efl/WebCoreSupport.

[Kenneth Rohde Christiansen]

Comment on attachment 50298 [details]
Add FrameLoaderClientEfl to WK/efl/WebCoreSupport.

On the mobile you probably want to say Mobile Safari and not Safari in the UA.


> +PassRefPtr<Frame> FrameLoaderClientEfl::createFrame(const KURL& url, const String& name, HTMLFrameOwnerElement* ownerElement,
> +                                                 const String& referrer, bool allowsScrolling, int marginWidth, int marginHeight)

Please keep these method definitions on one line.

Apart from that, it looks fine as an initial commit.

[Leandro Pereira]

Created attachment 53483 [details]
Add FrameLoaderClientEfl to WK/efl/WebCoreSupport.

Kenneth already r+'ed this patch.

I've fixed the createFrame definition.
Regarding the user agent, our API supports changing the user agent, so this won't be a huge issue if someone develops a mobile browser with the EFL port. This will be fixed, of course.

[WebKit Commit Bot]

Comment on attachment 53483 [details]
Add FrameLoaderClientEfl to WK/efl/WebCoreSupport.

Clearing flags on attachment: 53483

Committed r57716: <http://trac.webkit.org/changeset/57716>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.