Bug 35059 – New port: EFL; adding files to WebKit/efl

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Platform

[Leandro Pereira]

Created attachment 48940 [details]
Add EFL port files in WebKit/efl

This patch is part of a series of patches to add an updated version of the EFL port to the WebKit tree.

This particular patch adds files to WebKit/efl directory, including necessary image files (stored in webkit-efl-port-webkit_efl.tar, also attached). Changes to the port-independent parts and build system changes, will come later.

It should apply cleanly on SVN rev 54651.

[Leandro Pereira]

Created attachment 48941 [details]
Image files needed by the EFL port

[Gustavo Sverzut Barbieri]

I'm interested in the review process of this item, so adding it to CC.

ProFUSION wrote WebKit-EFL on behalf of Samsung Electronics, which now wants to contribute back and we'll maintain this port upstream as things should be ;-)

The port was based on previous attempt by INdT, however most of WebKit/efl was rewritten to fit better EFL architecture. The files that include INdT's work have their copyright listed accordingly.

[Leandro Pereira]

Changing platform to Other / Linux.

[Leandro Pereira]

Comment on attachment 48940 [details]
Add EFL port files in WebKit/efl

Mark patch for review.Mark patch for review.

[Kenneth Rohde Christiansen]

Comment on attachment 48940 [details]
Add EFL port files in WebKit/efl

It is a very big patch, would it be possible to split it up? Also, r- as there is no ChangeLog entry. 

Please use the prepare-ChangeLog to create ChangeLog entries. Also, read the page on webkit.org on how to contribute.

Also, we try to not commit out-commented code, please remove that.

[Gustavo Noronha (kov)]

(In reply to comment #5)
> (From update of attachment 48940 [details])
> It is a very big patch, would it be possible to split it up? Also, r- as there
> is no ChangeLog entry. 

I suggest a good first step would be to get enough build system in to build EFL's JavaScriptCore, what do you think?

[Leandro Pereira]

All files included in the attached patch either already landed (through smaller patches with their respective bug reports) or are awaiting review, so I am closing this bug.