Bug 85584 - Sort entries in FeaturesList.pm to make them easier to autogenerate
Summary: Sort entries in FeaturesList.pm to make them easier to autogenerate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 85456 85583
  Show dependency treegraph
 
Reported: 2012-05-03 23:32 PDT by Eric Seidel (no email)
Modified: 2012-05-04 16:10 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.56 KB, patch)
2012-05-03 23:33 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (8.44 KB, patch)
2012-05-04 15:27 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (7.69 KB, patch)
2012-05-04 15:50 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-05-03 23:32:34 PDT
Sort entries in FeaturesList.pm to make them easier to autogenerate
Comment 1 Eric Seidel (no email) 2012-05-03 23:33:26 PDT
Created attachment 140166 [details]
Patch
Comment 2 Daniel Bates 2012-05-04 14:28:52 PDT
Comment on attachment 140166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140166&action=review

> Tools/Scripts/webkitperl/FeatureList.pm:171
> +      define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isBlackBerry(), value =>\$downloadAttributeSupport },

Nit: There should be a space character before the "\$downloadAttributeSupport".

> Tools/Scripts/webkitperl/FeatureList.pm:306
>      { option => "style-scoped", desc => "Toggle <style scoped> support",
>        define => "ENABLE_STYLE_SCOPED", default => 0, value => \$styleScopedSupport },
>  
> +    { option => "sql-database", desc => "Toggle SQL Database Support",
> +      define => "ENABLE_SQL_DATABASE", default => 1, value => \$sqlDatabaseSupport },

The order of these entries should be reversed since "sql-database" comes before "style-scoped" in lexicographic order.
Comment 3 Eric Seidel (no email) 2012-05-04 15:27:36 PDT
Created attachment 140339 [details]
Patch for landing
Comment 4 Eric Seidel (no email) 2012-05-04 15:27:47 PDT
Fixed.  Thanks again for the reviews!
Comment 5 WebKit Review Bot 2012-05-04 15:29:14 PDT
Comment on attachment 140339 [details]
Patch for landing

Rejecting attachment 140339 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
iled to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 22.
2 out of 2 hunks FAILED -- saving rejects to file Tools/ChangeLog.rej
patching file Tools/Scripts/webkitperl/FeatureList.pm

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12637021
Comment 6 Daniel Bates 2012-05-04 15:38:44 PDT
Comment on attachment 140339 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=140339&action=review

> Tools/ChangeLog:20
> +2012-05-03  Eric Seidel  <eric@webkit.org>
> +
>          Split build-webkit's feature option list off into its own module in preparation for autogeneration
>          https://bugs.webkit.org/show_bug.cgi?id=85548
>  
> -        Reviewed by NOBODY (OOPS!).
> +        Reviewed by Daniel Bates.
>  
>          My perl-fu is very weak.  This moves the feature option list off into a separate module
>          file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.

Did you mean to change this?

> Tools/ChangeLog:37
> -        Reviewed by NOBODY (OOPS!).
> +        Reviewed by Daniel Bates.
>  

Ditto.
Comment 7 Daniel Bates 2012-05-04 15:42:48 PDT
(In reply to comment #6)
> (From update of attachment 140339 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140339&action=review
> 
> > Tools/ChangeLog:20
> > +2012-05-03  Eric Seidel  <eric@webkit.org>
> > +
> >          Split build-webkit's feature option list off into its own module in preparation for autogeneration
> >          https://bugs.webkit.org/show_bug.cgi?id=85548
> >  
> > -        Reviewed by NOBODY (OOPS!).
> > +        Reviewed by Daniel Bates.
> >  
> >          My perl-fu is very weak.  This moves the feature option list off into a separate module
> >          file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.
> 
> Did you mean to change this?
> 
> > Tools/ChangeLog:37
> > -        Reviewed by NOBODY (OOPS!).
> > +        Reviewed by Daniel Bates.
> >  
> 
> Ditto.

Disregard my last question. Both bug #85545 and bug #85548 were already landed. This patch needs to be rebased before it can be landed.
Comment 8 Eric Seidel (no email) 2012-05-04 15:50:23 PDT
Created attachment 140348 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-05-04 16:10:22 PDT
Comment on attachment 140348 [details]
Patch for landing

Clearing flags on attachment: 140348

Committed r116187: <http://trac.webkit.org/changeset/116187>
Comment 10 WebKit Review Bot 2012-05-04 16:10:30 PDT
All reviewed patches have been landed.  Closing bug.