Bug 85584 – Sort entries in FeaturesList.pm to make them easier to autogenerate

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Sort entries in FeaturesList.pm to make them easier to autogenerate

[Eric Seidel (no email)]

Created attachment 140166 [details]
Patch

[Daniel Bates]

Comment on attachment 140166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140166&action=review

> Tools/Scripts/webkitperl/FeatureList.pm:171
> +      define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isBlackBerry(), value =>\$downloadAttributeSupport },

Nit: There should be a space character before the "\$downloadAttributeSupport".

> Tools/Scripts/webkitperl/FeatureList.pm:306
>      { option => "style-scoped", desc => "Toggle <style scoped> support",
>        define => "ENABLE_STYLE_SCOPED", default => 0, value => \$styleScopedSupport },
>  
> +    { option => "sql-database", desc => "Toggle SQL Database Support",
> +      define => "ENABLE_SQL_DATABASE", default => 1, value => \$sqlDatabaseSupport },

The order of these entries should be reversed since "sql-database" comes before "style-scoped" in lexicographic order.

[Eric Seidel (no email)]

Created attachment 140339 [details]
Patch for landing

[Eric Seidel (no email)]

Fixed.  Thanks again for the reviews!

[WebKit Review Bot]

Comment on attachment 140339 [details]
Patch for landing

Rejecting attachment 140339 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
iled to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 22.
2 out of 2 hunks FAILED -- saving rejects to file Tools/ChangeLog.rej
patching file Tools/Scripts/webkitperl/FeatureList.pm

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12637021

[Daniel Bates]

Comment on attachment 140339 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=140339&action=review

> Tools/ChangeLog:20
> [phone]  Eric Seidel  <[e-mail]>
> +
>          Split build-webkit's feature option list off into its own module in preparation for autogeneration
>          https://bugs.webkit.org/show_bug.cgi?id=85548
>  
> -        Reviewed by NOBODY (OOPS!).
> +        Reviewed by Daniel Bates.
>  
>          My perl-fu is very weak.  This moves the feature option list off into a separate module
>          file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.

Did you mean to change this?

> Tools/ChangeLog:37
> -        Reviewed by NOBODY (OOPS!).
> +        Reviewed by Daniel Bates.
>  

Ditto.

[Daniel Bates]

(In reply to comment #6)
> (From update of attachment 140339 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140339&action=review
> 
> > Tools/ChangeLog:20
> > [phone]  Eric Seidel  <[e-mail]>
> > +
> >          Split build-webkit's feature option list off into its own module in preparation for autogeneration
> >          https://bugs.webkit.org/show_bug.cgi?id=85548
> >  
> > -        Reviewed by NOBODY (OOPS!).
> > +        Reviewed by Daniel Bates.
> >  
> >          My perl-fu is very weak.  This moves the feature option list off into a separate module
> >          file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.
> 
> Did you mean to change this?
> 
> > Tools/ChangeLog:37
> > -        Reviewed by NOBODY (OOPS!).
> > +        Reviewed by Daniel Bates.
> >  
> 
> Ditto.

Disregard my last question. Both bug #85545 and bug #85548 were already landed. This patch needs to be rebased before it can be landed.

[Eric Seidel (no email)]

Created attachment 140348 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 140348 [details]
Patch for landing

Clearing flags on attachment: 140348

Committed r116187: <http://trac.webkit.org/changeset/116187>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.