Bug 85548 - Split build-webkit's feature option list off into its own module in preparation for autogeneration
Summary: Split build-webkit's feature option list off into its own module in preparati...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 85456
  Show dependency treegraph
 
Reported: 2012-05-03 14:59 PDT by Eric Seidel (no email)
Modified: 2012-05-03 18:06 PDT (History)
5 users (show)

See Also:


Attachments
Patch (35.30 KB, patch)
2012-05-03 15:01 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (35.24 KB, patch)
2012-05-03 17:07 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-05-03 14:59:26 PDT
Split build-webkit's feature option list off into its own module in preparation for autogeneration
Comment 1 Eric Seidel (no email) 2012-05-03 15:01:51 PDT
Created attachment 140103 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-03 15:02:44 PDT
This won't actually apply until some of my earlier patches land.
Comment 3 Eric Seidel (no email) 2012-05-03 16:40:13 PDT
I did not sort or otherwise change the list (I just copied it).  I will post another patch to sort/cleanup this list once this is reviewed/landed.
Comment 4 Daniel Bates 2012-05-03 16:58:01 PDT
Comment on attachment 140103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140103&action=review

OK

> Tools/ChangeLog:8
> +        My perl-fu is very weak.  This moves the feature option list off into a separate module

Nit: perl => Perl
Comment 5 Eric Seidel (no email) 2012-05-03 17:07:03 PDT
Created attachment 140127 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-05-03 18:06:06 PDT
Comment on attachment 140127 [details]
Patch for landing

Clearing flags on attachment: 140127

Committed r116055: <http://trac.webkit.org/changeset/116055>
Comment 7 WebKit Review Bot 2012-05-03 18:06:20 PDT
All reviewed patches have been landed.  Closing bug.