Bug 85402 - Childlist mutations in shadow DOM should be observable with MutationObservers
Summary: Childlist mutations in shadow DOM should be observable with MutationObservers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks: 68729
  Show dependency treegraph
 
Reported: 2012-05-02 12:25 PDT by Adam Klein
Modified: 2012-05-02 15:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (7.17 KB, patch)
2012-05-02 12:29 PDT, Adam Klein
no flags Details | Formatted Diff | Diff
Patch for landing (7.22 KB, patch)
2012-05-02 12:37 PDT, Adam Klein
no flags Details | Formatted Diff | Diff
Patch with more tests (7.90 KB, patch)
2012-05-02 14:00 PDT, Adam Klein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2012-05-02 12:25:50 PDT
Childlist mutations in shadow DOM should be observable with MutationObservers
Comment 1 Adam Klein 2012-05-02 12:29:08 PDT
Created attachment 139859 [details]
Patch
Comment 2 Adam Klein 2012-05-02 12:37:43 PDT
Created attachment 139860 [details]
Patch for landing
Comment 3 Dimitri Glazkov (Google) 2012-05-02 12:45:12 PDT
Comment on attachment 139860 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=139860&action=review

> Source/WebCore/ChangeLog:13
> +        This patch moves code around to properly notify when childlist are
> +        mutated in shadow DOM and covers that change with a new test.

This doesn't leak elements in the shadow DOM subtree out to the document, right? Do we need a test for this?
Comment 4 Adam Klein 2012-05-02 13:22:37 PDT
(In reply to comment #3)
> (From update of attachment 139860 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139860&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        This patch moves code around to properly notify when childlist are
> > +        mutated in shadow DOM and covers that change with a new test.
> 
> This doesn't leak elements in the shadow DOM subtree out to the document, right? Do we need a test for this?

No leakage, since we just walk up the parent change to find subtree listeners.  Sounds like a good test to have, though.
Comment 5 Adam Klein 2012-05-02 14:00:01 PDT
Created attachment 139881 [details]
Patch with more tests
Comment 6 WebKit Review Bot 2012-05-02 15:03:33 PDT
Comment on attachment 139881 [details]
Patch with more tests

Clearing flags on attachment: 139881

Committed r115897: <http://trac.webkit.org/changeset/115897>
Comment 7 WebKit Review Bot 2012-05-02 15:03:43 PDT
All reviewed patches have been landed.  Closing bug.