Bug 85347 – [EFL] [DRT] Implement the LayoutTestController's methods which related to the Page Visibility API.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Dongwoo Joshua Im (dwim)]

The Page Visibility API has been already supported on the EFL port,
but DRT is not testing the API because setPageVisibility/resetPageVisibility methods are not implemented.

[Dongwoo Joshua Im (dwim)]

Created attachment 139748 [details]
Patch

First patch.

[WebKit Review Bot]

Attachment 139748 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Tools/DumpRenderTree/LayoutTestController.h:129:  The parameter name "visibility" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 139748 [details]
Patch

Attachment 139748 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12592749

[Early Warning System Bot]

Comment on attachment 139748 [details]
Patch

Attachment 139748 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12588754

[Dongwoo Joshua Im (dwim)]

Created attachment 139751 [details]
Patch

[WebKit Review Bot]

Attachment 139751 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 139751 [details]
Patch

Attachment 139751 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12585818

[Early Warning System Bot]

Comment on attachment 139751 [details]
Patch

Attachment 139751 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12587760

[Dongwoo Joshua Im (dwim)]

Created attachment 139756 [details]
Patch

Previous patch has bug number in the ChangeLog file, 
but it fail to style check because 'ChangeLog entry has no bug number'.

[Nikolas Zimmermann]

Comment on attachment 139756 [details]
Patch

rs=me.

[WebKit Review Bot]

Comment on attachment 139756 [details]
Patch

Clearing flags on attachment: 139756

Committed r115946: <http://trac.webkit.org/changeset/115946>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Nikolas Zimmermann]

This broke the mac build, landed fix in r115949.
Also dwim will post a follow-up patch that removes the "void LayoutTestController::setPageVisibility(const char* visibility)" " visibility" parameter name for ports that don't use it, so -Wall builds would work.

[Nikolas Zimmermann]

(In reply to comment #13)
> This broke the mac build, landed fix in r115949.
Note: the mac bot was green for this patch, that Dongwoo landed as-is, really weird. Anyhow, sorry for the trouble, if I knew before that mac wasn't building I wouldn't have rs'ed this.

[Nikolas Zimmermann]

Bug 85468 contains the other cleanup I've asked for, closing this bug.

[Chris Dumez]

Dongwoo, please check for duplicates (Bug 85347). We also have a collaboration wiki to avoid overlap.

The patch at Bug 85347 still has a few things not included in your patch so I will rebase and submit it anyway.

[Chris Dumez]

I meant Bug 85032.

[Dongwoo Joshua Im (dwim)]

(In reply to comment #16)
> Dongwoo, please check for duplicates (Bug 85347). We also have a collaboration wiki to avoid overlap.
> 
> The patch at Bug 85347 still has a few things not included in your patch so I will rebase and submit it anyway.

Dear Christophe, 
I didn't recognized this is duplicated.

Sorry about that.