Bug 85032 – [EFL][DRT] EFL's DRT does not fully support page visibility

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

setPageVisibility() and resetPageVisibility() need to be implemented in EFL's LayoutTestController.

[Chris Dumez]

Created attachment 139148 [details]
Patch

[Chris Dumez]

Created attachment 139779 [details]
Patch

Rebase on master and call DumpRenderTreeSupportEfl::resetPageVisibility() from DumpRenderTreeChrome::resetDefaultsToConsistentValues() for safety.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 139779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139779&action=review

> Tools/ChangeLog:8
> +        Implement page visibility API support in EFL's DRT.

This is a very laconic description :-) Not only do you plug the EFL bits, but you also fix the argumentCount check in LTC and add stubs to the other ports' LTCs, so a better description (either here or in the method list below) would be very welcome.

> Tools/DumpRenderTree/LayoutTestController.cpp:1746
>      // Has mac & windows implementation

I think this comment can go away too.

> Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:902
> +    // FIXME: implement.

We generally add a notImplemented() call instead (this applies to all the other FIXME comments).

[Chris Dumez]

It seems there is some overlap with Samsung's patch at Bug 85347 (which already landed). I will rebase my patch since some functionality is missing in Samsung's patch.

[Chris Dumez]

Created attachment 140483 [details]
Patch

Rebase patch due to Bug 85347. Remaining in the patch:
- Properly reset visibility state between tests
- Add support for "preview" visibility state
- Fix argumentCount check in resetPageVisibilityCallback()
- Unskip remaining page visibility tests in EFL

[Gyuyoung Kim]

Comment on attachment 140483 [details]
Patch

Looks fine to me.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 140483 [details]
Patch

Looks great, thank you.

[WebKit Review Bot]

Comment on attachment 140483 [details]
Patch

Clearing flags on attachment: 140483

Committed r116416: <http://trac.webkit.org/changeset/116416>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.