Bug 85276 - PNGImageDecoder: Handle interlace buffer allocation failure
Summary: PNGImageDecoder: Handle interlace buffer allocation failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-01 05:49 PDT by noel gordon
Modified: 2012-05-03 19:25 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.19 KB, patch)
2012-05-01 05:50 PDT, noel gordon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2012-05-01 05:49:09 PDT 
PNGImageDEcoder: Handle interlace buffer allocation failure
Comment 1 noel gordon 2012-05-01 05:50:15 PDT 
Created attachment 139617 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-01 19:12:39 PDT 
Comment on attachment 139617 [details]
Patch

Do we have an image we can test this with?  It seems if we keep maintaining a PNG decoder (which we really *don't* want to do as a project), we will need to come up with a testing harness and a corpus of a bunch of broken png files. :(
Comment 3 noel gordon 2012-05-01 19:24:15 PDT 
No, no test image sorry.  Agree we need to come up with a better test suite.
Comment 4 noel gordon 2012-05-01 19:28:29 PDT 
So it's impractical to test this with our current technology, but the plan is to move towards using pngsuite for testing our decoder, which should catch issues like this one.  http://www.schaik.com/pngsuite
Comment 5 Eric Seidel (no email) 2012-05-01 19:29:21 PDT 
Comment on attachment 139617 [details]
Patch

OK.
Comment 6 WebKit Review Bot 2012-05-01 20:19:48 PDT 
Comment on attachment 139617 [details]
Patch

Clearing flags on attachment: 139617

Committed r115784: <http://trac.webkit.org/changeset/115784>
Comment 7 WebKit Review Bot 2012-05-01 20:19:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 noel gordon 2012-05-02 23:55:43 PDT 
(In reply to comment #4)
> So it's impractical to test this with our current technology, but the plan is to move towards using pngsuite for testing our decoder, which should catch issues like this one.  http://www.schaik.com/pngsuite

"may help catch issues like this one", filed bug 85460
Comment 9 noel gordon 2012-05-03 19:25:51 PDT 
Closed bug 85460 (too much broken style bot noise). Filed bug 85567.