Bug 85567 - Add PNG image pngsuite test
Summary: Add PNG image pngsuite test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-03 18:30 PDT by noel gordon
Modified: 2012-05-04 03:37 PDT (History)
5 users (show)

See Also:


Attachments
Patch (584.64 KB, patch)
2012-05-03 18:49 PDT, noel gordon
no flags Details | Formatted Diff | Diff
Patch merge to tip (584.59 KB, patch)
2012-05-03 23:40 PDT, noel gordon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2012-05-03 18:30:44 PDT
Add PNG image pngsuite from http://www.schaik.com/pngsuite
Comment 1 noel gordon 2012-05-03 18:49:02 PDT
Created attachment 140144 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-03 22:51:58 PDT
Comment on attachment 140144 [details]
Patch

Fantastic!
Comment 3 WebKit Review Bot 2012-05-03 22:58:20 PDT
Comment on attachment 140144 [details]
Patch

Rejecting attachment 140144 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/platform/efl/test_expectations.txt.rej
patching file LayoutTests/platform/gtk/test_expectations.txt
patching file LayoutTests/platform/qt/test_expectations.txt
Hunk #1 FAILED at 64.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/test_expectations.txt.rej
patching file LayoutTests/platform/wincairo/Skipped

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12633054
Comment 4 noel gordon 2012-05-03 23:40:49 PDT
Created attachment 140167 [details]
Patch merge to tip
Comment 5 WebKit Review Bot 2012-05-04 00:24:43 PDT
Comment on attachment 140167 [details]
Patch merge to tip

Clearing flags on attachment: 140167

Committed r116074: <http://trac.webkit.org/changeset/116074>
Comment 6 WebKit Review Bot 2012-05-04 00:24:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Andrey Kosyakov 2012-05-04 03:21:51 PDT
FWIW, the chromium tests fail with missing result -- so I changed the expectations from IMAGE to MISSING.
Comment 8 noel gordon 2012-05-04 03:33:15 PDT
Thanks, had the expectation as = IMAGE MISSING and the linux EWS complained about that :(
Comment 9 noel gordon 2012-05-04 03:37:29 PDT
Landed chromium rebaselines n http://trac.webkit.org/changeset/116081