Bug 85207 - [V8][JSC] Remove hard-coded "Not enough arguments" errors
: [V8][JSC] Remove hard-coded "Not enough arguments" errors
Status: RESOLVED FIXED
: WebKit
WebCore JavaScript
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 84074
  Show dependency treegraph
 
Reported: 2012-04-30 10:46 PST by
Modified: 2012-04-30 14:36 PST (History)


Attachments
Patch (10.07 KB, patch)
2012-04-30 10:49 PST, Kentaro Hara
no flags Review Patch | Details | Formatted Diff | Diff
Patch (10.09 KB, patch)
2012-04-30 10:58 PST, Kentaro Hara
no flags Review Patch | Details | Formatted Diff | Diff
Patch (10.09 KB, patch)
2012-04-30 11:07 PST, Kentaro Hara
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-30 10:46:11 PST
In bug 85022 and bug 85097, we implemented createNotEnoughArgumentsError() in JSC and V8Proxy::throwNotEnoughArgumentsError() in V8 and partially removed hard-coded "Not enough arguments" errors. In this bug, we remove hard-coded "Not enough arguments" errors by using the helper methods.
------- Comment #1 From 2012-04-30 10:49:26 PST -------
Created an attachment (id=139476) [details]
Patch
------- Comment #2 From 2012-04-30 10:54:12 PST -------
(From update of attachment 139476 [details])
Attachment 139476 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12584341
------- Comment #3 From 2012-04-30 10:54:30 PST -------
(From update of attachment 139476 [details])
Attachment 139476 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12584344
------- Comment #4 From 2012-04-30 10:57:24 PST -------
(From update of attachment 139476 [details])
Attachment 139476 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12590287
------- Comment #5 From 2012-04-30 10:58:26 PST -------
Created an attachment (id=139478) [details]
Patch
------- Comment #6 From 2012-04-30 11:02:48 PST -------
(From update of attachment 139478 [details])
Attachment 139478 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12585342
------- Comment #7 From 2012-04-30 11:03:41 PST -------
(From update of attachment 139478 [details])
Attachment 139478 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12595218
------- Comment #8 From 2012-04-30 11:04:04 PST -------
(From update of attachment 139478 [details])
Attachment 139478 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12598117
------- Comment #9 From 2012-04-30 11:07:48 PST -------
Created an attachment (id=139483) [details]
Patch
------- Comment #10 From 2012-04-30 14:36:35 PST -------
(From update of attachment 139483 [details])
Clearing flags on attachment: 139483

Committed r115670: <http://trac.webkit.org/changeset/115670>
------- Comment #11 From 2012-04-30 14:36:43 PST -------
All reviewed patches have been landed.  Closing bug.