Bug 85207 - [V8][JSC] Remove hard-coded "Not enough arguments" errors
: [V8][JSC] Remove hard-coded "Not enough arguments" errors
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Kentaro Hara
:
Depends on:
Blocks: 84074
  Show dependency treegraph
 
Reported: 2012-04-30 10:46 PDT by Kentaro Hara
Modified: 2012-04-30 14:36 PDT (History)
9 users (show)

See Also:


Attachments
Patch (10.07 KB, patch)
2012-04-30 10:49 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (10.09 KB, patch)
2012-04-30 10:58 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (10.09 KB, patch)
2012-04-30 11:07 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-04-30 10:46:11 PDT
In bug 85022 and bug 85097, we implemented createNotEnoughArgumentsError() in JSC and V8Proxy::throwNotEnoughArgumentsError() in V8 and partially removed hard-coded "Not enough arguments" errors. In this bug, we remove hard-coded "Not enough arguments" errors by using the helper methods.
Comment 1 Kentaro Hara 2012-04-30 10:49:26 PDT
Created attachment 139476 [details]
Patch
Comment 2 Early Warning System Bot 2012-04-30 10:54:12 PDT
Comment on attachment 139476 [details]
Patch

Attachment 139476 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12584341
Comment 3 Philippe Normand 2012-04-30 10:54:30 PDT
Comment on attachment 139476 [details]
Patch

Attachment 139476 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12584344
Comment 4 Early Warning System Bot 2012-04-30 10:57:24 PDT
Comment on attachment 139476 [details]
Patch

Attachment 139476 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12590287
Comment 5 Kentaro Hara 2012-04-30 10:58:26 PDT
Created attachment 139478 [details]
Patch
Comment 6 Early Warning System Bot 2012-04-30 11:02:48 PDT
Comment on attachment 139478 [details]
Patch

Attachment 139478 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12585342
Comment 7 Philippe Normand 2012-04-30 11:03:41 PDT
Comment on attachment 139478 [details]
Patch

Attachment 139478 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12595218
Comment 8 Early Warning System Bot 2012-04-30 11:04:04 PDT
Comment on attachment 139478 [details]
Patch

Attachment 139478 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12598117
Comment 9 Kentaro Hara 2012-04-30 11:07:48 PDT
Created attachment 139483 [details]
Patch
Comment 10 WebKit Review Bot 2012-04-30 14:36:35 PDT
Comment on attachment 139483 [details]
Patch

Clearing flags on attachment: 139483

Committed r115670: <http://trac.webkit.org/changeset/115670>
Comment 11 WebKit Review Bot 2012-04-30 14:36:43 PDT
All reviewed patches have been landed.  Closing bug.