Bug 85097 - [V8] Implement a helper method V8Proxy::throwNotEnoughArgumentsError()
Summary: [V8] Implement a helper method V8Proxy::throwNotEnoughArgumentsError()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency treegraph
 
Reported: 2012-04-27 13:53 PDT by Kentaro Hara
Modified: 2012-04-27 18:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (9.42 KB, patch)
2012-04-27 14:13 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (9.52 KB, patch)
2012-04-27 14:15 PDT, Kentaro Hara
haraken: commit-queue-
Details | Formatted Diff | Diff
patch for landing (40.96 KB, patch)
2012-04-27 15:39 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-04-27 13:53:55 PDT
In bug 84787, kbr requested to avoid hard-coding throwError("Not enough arguments", V8Proxy::TypeError) here and there. In this bug we implement V8Proxy::throwNotEnoughArgumentsError() and use it in V8 bindings.

I'll write another patch for JSC bindings.
Comment 1 Kentaro Hara 2012-04-27 14:13:56 PDT
Created attachment 139274 [details]
Patch
Comment 2 Kentaro Hara 2012-04-27 14:15:23 PDT
Created attachment 139276 [details]
Patch
Comment 3 Kenneth Russell 2012-04-27 14:56:31 PDT
Comment on attachment 139276 [details]
Patch

Looks good. r=me
Comment 4 Kentaro Hara 2012-04-27 15:39:39 PDT
Comment on attachment 139276 [details]
Patch

Forgot to update run-bindings-tests results...
Comment 5 Kentaro Hara 2012-04-27 15:39:48 PDT
Created attachment 139294 [details]
patch for landing
Comment 6 WebKit Review Bot 2012-04-27 18:00:06 PDT
Comment on attachment 139294 [details]
patch for landing

Clearing flags on attachment: 139294

Committed r115522: <http://trac.webkit.org/changeset/115522>