Bug 85112 - Add ‎ ‏ and   to WebVTT parser
Summary: Add ‎ ‏ and   to WebVTT parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks: 85035
  Show dependency tree / graph
 
Reported: 2012-04-27 17:07 PDT by Anna Cavender
Modified: 2014-01-21 10:39 PST (History)
7 users (show)

See Also:

Attachments
Proposed patch (6.51 KB, patch)
2014-01-20 15:17 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Cavender 2012-04-27 17:07:17 PDT 
‎ ‏ and   were recently added to the WebVTT spec

http://dev.w3.org/html5/webvtt/#webvtt-cue-components
Comment 1 David Kilzer (:ddkilzer) 2014-01-18 19:47:11 PST 
Fixed in Blink:  http://src.chromium.org/viewvc/blink?view=revision&revision=161822
Comment 3 Eric Carlson 2014-01-20 15:15:46 PST 
I have had changes for this in my local repository for a while, guess I forgot to post a patch.
Comment 4 Eric Carlson 2014-01-20 15:17:43 PST 
Created attachment 221697 [details]
Proposed patch
Comment 5 Eric Carlson 2014-01-21 08:02:59 PST 
Doesn't look like the efl failure has anything to do with this patch:

Last 500 characters of output:
ing CXX object Source/WebCore/CMakeFiles/WebCore.dir/dom/ScriptedAnimationController.cpp.o
c++: internal compiler error: Killed (program cc1plus)
Comment 6 Jer Noble 2014-01-21 09:54:14 PST 
Comment on attachment 221697 [details]
Proposed patch

r=me
Comment 7 WebKit Commit Bot 2014-01-21 10:39:41 PST 
Comment on attachment 221697 [details]
Proposed patch

Clearing flags on attachment: 221697

Committed r162450: <http://trac.webkit.org/changeset/162450>
Comment 8 WebKit Commit Bot 2014-01-21 10:39:43 PST 
All reviewed patches have been landed.  Closing bug.