Bug 85102 - [JSC] Implement a helper method createNotEnoughArgumentsError()
Summary: [JSC] Implement a helper method createNotEnoughArgumentsError()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency treegraph
 
Reported: 2012-04-27 15:29 PDT by Kentaro Hara
Modified: 2012-04-28 03:33 PDT (History)
10 users (show)

See Also:


Attachments
Patch (47.35 KB, patch)
2012-04-27 15:34 PDT, Kentaro Hara
buildbot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (48.16 KB, patch)
2012-04-27 19:32 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-04-27 15:29:15 PDT
In bug 84787, kbr@ requested to avoid hard-coding createTypeError(exec, "Not enough arguments") here and there. In this bug we implement createNotEnoughArgumentsError(exec) and use it in JSC bindings.

c.f. a corresponding bug for V8 bindings: bug 85097.
Comment 1 Kentaro Hara 2012-04-27 15:34:59 PDT
Created attachment 139292 [details]
Patch
Comment 2 Geoffrey Garen 2012-04-27 15:47:06 PDT
Comment on attachment 139292 [details]
Patch

r=me

Nice cleanup.
Comment 3 Build Bot 2012-04-27 16:25:36 PDT
Comment on attachment 139292 [details]
Patch

Attachment 139292 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12534353
Comment 4 Kentaro Hara 2012-04-27 19:32:28 PDT
Created attachment 139325 [details]
patch for landing
Comment 5 WebKit Review Bot 2012-04-27 20:57:49 PDT
Comment on attachment 139325 [details]
patch for landing

Clearing flags on attachment: 139325

Committed r115536: <http://trac.webkit.org/changeset/115536>