Bug 85051 - Fix repetitions & by animation support for SVGAnimateTransformElement
: Fix repetitions & by animation support for SVGAnimateTransformElement
Status: RESOLVED FIXED
: WebKit
SVG
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
: 84968
: 36729 41761 85133
  Show dependency treegraph
 
Reported: 2012-04-27 04:47 PST by
Modified: 2012-04-28 04:22 PST (History)


Attachments
Patch (69.79 KB, patch)
2012-04-27 04:54 PST, Nikolas Zimmermann
no flags Review Patch | Details | Formatted Diff | Diff
Patch v2 (69.74 KB, patch)
2012-04-27 06:59 PST, Nikolas Zimmermann
koivisto: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-27 04:47:08 PST
Repetitions are currently handled by adjusting percentage (percentage += repeatCount). This doesn't work for <animateTransform> as each repetition has to be post-multiplied to the animated transform list.
By-animations are equal to values="0;by" animations in SMIL. 0 is the neutral element of addition, which is the _zero_ matrix, not the identity matrix for SVGTransform.
See moz guys discussing the same problem, with the same outcome: http://brian.sol1.net/svg/animatetransform-issues/by-animation-and-scale-transformations/
------- Comment #1 From 2012-04-27 04:54:53 PST -------
Created an attachment (id=139171) [details]
Patch
------- Comment #2 From 2012-04-27 05:00:53 PST -------
(From update of attachment 139171 [details])
Attachment 139171 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12557170
------- Comment #3 From 2012-04-27 05:03:50 PST -------
(From update of attachment 139171 [details])
Attachment 139171 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12556176
------- Comment #4 From 2012-04-27 05:08:47 PST -------
(From update of attachment 139171 [details])
Attachment 139171 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12551178
------- Comment #5 From 2012-04-27 06:58:42 PST -------
Uploading patch v2, which will fix the release builds.
------- Comment #6 From 2012-04-27 06:59:36 PST -------
Created an attachment (id=139192) [details]
Patch v2
------- Comment #7 From 2012-04-27 07:02:51 PST -------
(From update of attachment 139192 [details])
r=me
------- Comment #8 From 2012-04-27 07:10:22 PST -------
Committed r115425: <http://trac.webkit.org/changeset/115425>