Bug 85051 - Fix repetitions & by animation support for SVGAnimateTransformElement
Summary: Fix repetitions & by animation support for SVGAnimateTransformElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on: 84968
Blocks: 41761 36729 85133
  Show dependency tree / graph
 
Reported: 2012-04-27 04:47 PDT by Nikolas Zimmermann
Modified: 2012-04-28 04:22 PDT (History)
1 user (show)

See Also:

Attachments
Patch (69.79 KB, patch)
2012-04-27 04:54 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch v2 (69.74 KB, patch)
2012-04-27 06:59 PDT, Nikolas Zimmermann 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2012-04-27 04:47:08 PDT 
Repetitions are currently handled by adjusting percentage (percentage += repeatCount). This doesn't work for <animateTransform> as each repetition has to be post-multiplied to the animated transform list.
By-animations are equal to values="0;by" animations in SMIL. 0 is the neutral element of addition, which is the _zero_ matrix, not the identity matrix for SVGTransform.
See moz guys discussing the same problem, with the same outcome: http://brian.sol1.net/svg/animatetransform-issues/by-animation-and-scale-transformations/
Comment 1 Nikolas Zimmermann 2012-04-27 04:54:53 PDT 
Created attachment 139171 [details]
Patch
Comment 2 Early Warning System Bot 2012-04-27 05:00:53 PDT 
Comment on attachment 139171 [details]
Patch

Attachment 139171 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12557170
Comment 3 Early Warning System Bot 2012-04-27 05:03:50 PDT 
Comment on attachment 139171 [details]
Patch

Attachment 139171 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12556176
Comment 4 Build Bot 2012-04-27 05:08:47 PDT 
Comment on attachment 139171 [details]
Patch

Attachment 139171 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12551178
Comment 5 Nikolas Zimmermann 2012-04-27 06:58:42 PDT 
Uploading patch v2, which will fix the release builds.
Comment 6 Nikolas Zimmermann 2012-04-27 06:59:36 PDT 
Created attachment 139192 [details]
Patch v2
Comment 7 Antti Koivisto 2012-04-27 07:02:51 PDT 
Comment on attachment 139192 [details]
Patch v2

r=me
Comment 8 Nikolas Zimmermann 2012-04-27 07:10:22 PDT 
Committed r115425: <http://trac.webkit.org/changeset/115425>