Bug 85049 – Rename deviceDPI to devicePixelRatio

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Alexander Færøy]

SSIA.

[Alexander Færøy]

Created attachment 139794 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 139794 [details]
Patch

In the future lets add documentation

[Konrad Piascik]

Comment on attachment 139794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139794&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:893
> +    ViewportAttributes attr = computeViewportAttributes(m_page->viewportArguments(), minimumLayoutFallbackWidth, settings->deviceWidth(), settings->deviceHeight(), 160 * settings->devicePixelRatio(), m_viewportSize);

How is this correct?  devicePixelRatio is supposed to be a double, but device DPI is an int.  These are 2 different properties aren't they?  You can't pass devicePixelRatio into the deviceDPI value for computeViewportAttributers.

[Jesus Sanchez-Palencia]

(In reply to comment #2)
> (From update of attachment 139794 [details])
> In the future lets add documentation

<nitpicking> I think the bug title here is a bit misleading on a first glance since this patch is more about adding the experimental API than actually refactoring that piece of code. 2 cents for the future ;) </nitpicking>

[Alexander Færøy]

Created attachment 139803 [details]
Patch

[Alexander Færøy]

Committed r115948: <http://trac.webkit.org/changeset/115948>

[Csaba Osztrogonác]

Reopen, because it broke an API test on Qt5-WK2:
FAIL!  : tst_QQuickWebView::scrollRequest() 'webView()->contentY() == y' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(400)]

Could you check and fix it?

[Alexander Færøy]

Created attachment 139979 [details]
Patch

[Alexander Færøy]

Committed r115955: <http://trac.webkit.org/changeset/115955>