Bug 85041 - [EFL][WK2] Compile webkit1 and webkit2 by default.
Summary: [EFL][WK2] Compile webkit1 and webkit2 by default.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 61838
  Show dependency treegraph
 
Reported: 2012-04-27 02:32 PDT by Mariusz Grzegorczyk
Modified: 2012-06-06 21:26 PDT (History)
8 users (show)

See Also:


Attachments
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script (1.30 KB, patch)
2012-04-27 02:35 PDT, Mariusz Grzegorczyk
no flags Details | Formatted Diff | Diff
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script (1.30 KB, patch)
2012-05-31 11:04 PDT, Mariusz Grzegorczyk
no flags Details | Formatted Diff | Diff
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script (1.32 KB, patch)
2012-06-05 04:54 PDT, Mariusz Grzegorczyk
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mariusz Grzegorczyk 2012-04-27 02:32:23 PDT
There is no option to build EFL's webkit2 from Tools/Scripts/build-webkit script.
Comment 1 Mariusz Grzegorczyk 2012-04-27 02:35:32 PDT
Created attachment 139156 [details]
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script
Comment 2 Gyuyoung Kim 2012-05-22 22:14:35 PDT
Comment on attachment 139156 [details]
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script

Basically, looks good to me. However, can efl webkit2 be built on trunk ?
Comment 3 Mariusz Grzegorczyk 2012-05-23 01:02:20 PDT
(In reply to comment #2)
> (From update of attachment 139156 [details])
> Basically, looks good to me. However, can efl webkit2 be built on trunk ?

If all related patches will be merged, webkit2 can be built on trunk like gtk port.
Comment 4 Dominik Röttsches (drott) 2012-05-28 07:43:14 PDT
Mariusz, I am seeing the same issue as the EWS on my machine:
"-- Configuring done
CMake Error in Source/WebKit2/CMakeLists.txt:
  Cannot find source file "WebCoreArgumentCodersEfl.cpp".  Tried extensions
  .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx"

I am looking into it.
Comment 5 Ryuan Choi 2012-05-31 05:40:10 PDT
mariusz, Could you rebase the patch?

I think that WebKit/Efl will be compiled in ews now.
Comment 6 Gyuyoung Kim 2012-05-31 05:57:34 PDT
I think we need to support --only-webkit and --no-webkit2 options for EFL port.

For example, GTK port supports this option as below,
 - http://trac.webkit.org/browser/trunk/Tools/Scripts/build-webkit#L365

If possible, could you support this option as well?
Comment 7 Mariusz Grzegorczyk 2012-05-31 11:03:42 PDT
(In reply to comment #6)
> I think we need to support --only-webkit and --no-webkit2 options for EFL port.
> 
> For example, GTK port supports this option as below,
>  - http://trac.webkit.org/browser/trunk/Tools/Scripts/build-webkit#L365
> 
> If possible, could you support this option as well?

--no-webkit2 option is used as $noWebKit2 variable, and --only-webkit is as I see platform independent
Comment 8 Mariusz Grzegorczyk 2012-05-31 11:04:57 PDT
Created attachment 145116 [details]
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script

Rebased.
Comment 9 Ryuan Choi 2012-05-31 16:30:22 PDT
(In reply to comment #8)
> Created an attachment (id=145116) [details]
> Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script
> 
> Rebased.

Thank you. informal r+ on my side.
Comment 10 Gyuyoung Kim 2012-05-31 17:31:36 PDT
Looks good to me. Thanks.
Comment 11 Raphael Kubo da Costa (:rakuco) 2012-06-01 07:17:16 PDT
Comment on attachment 145116 [details]
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script

View in context: https://bugs.webkit.org/attachment.cgi?id=145116&action=review

It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt.

> Tools/Scripts/build-webkit:677
> +    $cmakeArgs .= ($cmakeArgs ? " " : "") . "-DENABLE_WEBKIT=On";
> +    $cmakeArgs .= " -DENABLE_WEBKIT2=On" if !$noWebKit2;

Style nit: we generally use "ON" instead of "On".
Comment 12 Mariusz Grzegorczyk 2012-06-04 04:37:58 PDT
> It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt.

Hm, I've ran webkit build like on EWS "perl ./Tools/Scripts/build-webkit --release --efl" and both webkit1 and webkit2 were built. In CMakeCache.txt I have "ENABLE_WEBKIT2:UNINITIALIZED=On". Is this right command, or EWS makes something extra?
Comment 13 Gyuyoung Kim 2012-06-04 18:15:13 PDT
(In reply to comment #12)

EWS is compiling webkit using "Tools/Scripts/build-webkit --efl". If there is no problems when you build WebKit with your patches, I think EWS also won't have problems.(In reply to comment #12)
> > It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt.
> 
> Hm, I've ran webkit build like on EWS "perl ./Tools/Scripts/build-webkit --release --efl" and both webkit1 and webkit2 were built. In CMakeCache.txt I have "ENABLE_WEBKIT2:UNINITIALIZED=On". Is this right command, or EWS makes something extra?

If the feature is not defined in WebKitFeatures, UNINITIALIZED is added to CMakeCache.txt. But, I think we don't need to add ENABLE_WEBKIT2 to WebKitFeatures yet.

http://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake#L14

I ran webkit1 and webkit2 with this patch. Then, I could get both libewebkit2.so and libewebkit.so. It seems to me there is no problem. 

Kubo, do you think ENABLE_WEBKIT2 is off yet ?

Mariusz, as kubo said, you need to use uppercase for "On".
Comment 14 Mariusz Grzegorczyk 2012-06-05 04:54:39 PDT
Created attachment 145759 [details]
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script

Rebased, make changes pointed by Raphael
Comment 15 Grzegorz Czajkowski 2012-06-06 05:30:22 PDT
LGTM.
Comment 16 Gyuyoung Kim 2012-06-06 19:45:13 PDT
Comment on attachment 145759 [details]
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script

Looks good to me.
Comment 17 Ryuan Choi 2012-06-06 19:46:16 PDT
LGTM too.
Comment 18 WebKit Review Bot 2012-06-06 21:26:40 PDT
Comment on attachment 145759 [details]
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script

Clearing flags on attachment: 145759

Committed r119678: <http://trac.webkit.org/changeset/119678>
Comment 19 WebKit Review Bot 2012-06-06 21:26:46 PDT
All reviewed patches have been landed.  Closing bug.