Bug 84963 - [EFL] Fix the build with DRAG_SUPPORT disabled.
Summary: [EFL] Fix the build with DRAG_SUPPORT disabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks: 84952
  Show dependency treegraph
 
Reported: 2012-04-26 08:07 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-04-27 03:15 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.89 KB, patch)
2012-04-26 08:08 PDT, Raphael Kubo da Costa (:rakuco)
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-04-26 08:07:20 PDT
[EFL] Fix the build with DRAG_SUPPORT disabled.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-04-26 08:08:34 PDT
Created attachment 139004 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-04-26 08:15:05 PDT
Committed r115318: <http://trac.webkit.org/changeset/115318>
Comment 3 Dominik Röttsches (drott) 2012-04-27 00:44:30 PDT
After build 706 on the Debug buildbot which had the DRAG support change, as well as the scrolling changes for CMake 
http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/706
we see a couple of new failures:

fast/css/user-drag-none.html
fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
fast/events/autoscroll-should-not-stop-on-keypress.html
fast/forms/select-multiple-elements-with-mouse-drag.html
fast/repaint/repaint-across-writing-mode-boundary.html
fast/repaint/selection-rl.html
fast/text/reset-drag-on-mouse-down.html
fast/writing-mode/horizontal-bt-replaced-selection.html
fast/writing-mode/vertical-lr-replaced-selection.html
fast/writing-mode/vertical-rl-replaced-selection.html
Comment 4 Thiago Marcos P. Santos 2012-04-27 00:48:32 PDT
(In reply to comment #3)
> After build 706 on the Debug buildbot which had the DRAG support change, as well as the scrolling changes for CMake 
> http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/706
> we see a couple of new failures:
> 
> fast/css/user-drag-none.html
> fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
> fast/events/autoscroll-should-not-stop-on-keypress.html
> fast/forms/select-multiple-elements-with-mouse-drag.html
> fast/repaint/repaint-across-writing-mode-boundary.html
> fast/repaint/selection-rl.html
> fast/text/reset-drag-on-mouse-down.html
> fast/writing-mode/horizontal-bt-replaced-selection.html
> fast/writing-mode/vertical-lr-replaced-selection.html
> fast/writing-mode/vertical-rl-replaced-selection.html

I'm investigating if those tests are really failing or if they just need rebaselining.
Comment 5 Thiago Marcos P. Santos 2012-04-27 03:15:00 PDT
I had to remove the CMakeCache.txt from the bot. Failure count is back to normal.