Bug 84952 - [BlackBerry] properly disable DRAG_SUPPORT
: [BlackBerry] properly disable DRAG_SUPPORT
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
: 84963
:
  Show dependency treegraph
 
Reported: 2012-04-26 06:52 PST by
Modified: 2012-04-26 13:32 PST (History)


Attachments
patch (3.51 KB, patch)
2012-04-26 07:00 PST, Antonio Gomes
gyuyoung.kim: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
(r115348, r=dbates) patch v2 - fixed EFL build (4.29 KB, patch)
2012-04-26 08:09 PST, Antonio Gomes
dbates: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-26 06:52:39 PST
We were hardcoding "ENABLE_DRAG_SUPPORT 0" in Platform.h

We should do it with CMake's help instead.
------- Comment #1 From 2012-04-26 07:00:05 PST -------
Created an attachment (id=138994) [details]
patch
------- Comment #2 From 2012-04-26 07:51:33 PST -------
(From update of attachment 138994 [details])
Attachment 138994 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12517943
------- Comment #3 From 2012-04-26 08:09:50 PST -------
Created an attachment (id=139005) [details]
patch v2 - fixed EFL build
------- Comment #4 From 2012-04-26 10:36:22 PST -------
@paroga, with patch we have to manually enable DRAG support in options{WinCE,Win}.cmake files. Are you ok with that?
------- Comment #5 From 2012-04-26 10:41:52 PST -------
(From update of attachment 139005 [details])
We should probably enable drag support for Windows. Currently, it defaults to off by <http://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake?rev=114113#L30>.

r=me
------- Comment #6 From 2012-04-26 13:32:43 PST -------
(From update of attachment 139005 [details])
Committed: <http://trac.webkit.org/changeset/115348>