Bug 84853 - Share code used to animate discrete types between all animators
Summary: Share code used to animate discrete types between all animators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 41761
  Show dependency treegraph
 
Reported: 2012-04-25 06:05 PDT by Nikolas Zimmermann
Modified: 2012-04-26 00:52 PDT (History)
1 user (show)

See Also:


Attachments
Patch (24.51 KB, patch)
2012-04-25 06:08 PDT, Nikolas Zimmermann
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2012-04-25 06:05:02 PDT
Share code used to animate discrete types between all animators.
Comment 1 Nikolas Zimmermann 2012-04-25 06:08:26 PDT
Created attachment 138797 [details]
Patch
Comment 2 Andreas Kling 2012-04-26 00:44:57 PDT
Comment on attachment 138797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138797&action=review

Great cleanup, and you're adding a test. What's not to love? r=me

> Source/WebCore/svg/SVGAnimateElement.h:52
> +    virtual bool isAdditive() const;

We should add OVERRIDE here.
Comment 3 Nikolas Zimmermann 2012-04-26 00:52:04 PDT
Committed r115296: <http://trac.webkit.org/changeset/115296>