Calendar Picker: Resize to minimal size to fit the content
Created attachment 138739 [details] Patch
Keishi, would you do informal review for the patch please?
Comment on attachment 138739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138739&action=review > Source/WebCore/ChangeLog:13 > + The minimal size depends on font settings, localized labels, and > + localizaed formats. So we put objects on a trasparent element, calculate > + minimal size, resize the popup, then show the objects. Does this mean it would be difficult to add pixel tests for the change? I might want to see some test.
(In reply to comment #3) > (From update of attachment 138739 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138739&action=review > > > Source/WebCore/ChangeLog:13 > > + The minimal size depends on font settings, localized labels, and > > + localizaed formats. So we put objects on a trasparent element, calculate > > + minimal size, resize the popup, then show the objects. > > Does this mean it would be difficult to add pixel tests for the change? I might want to see some test. No, because we assume test environment is homogeneous. But DRT can't capture the content of popups at all. I have a plain to add tests later. We need to solve Bug 84827.
Comment on attachment 138739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138739&action=review Looks good to me. > Source/WebCore/Resources/calendarPicker.css:52 > + opacity: 0.3; It is impossible to notice for a 0.1s animation, but isn't it better to start completely invisible and set the starting opacity inside the fixWindowSize function?
Created attachment 138749 [details] Patch 2 initial opacity, and some typos
Delegating review to morrita-san.
Comment on attachment 138749 [details] Patch 2 Hopes to have tests somehow. rs=me
Committed r115276: <http://trac.webkit.org/changeset/115276>