Bug 85331 - Calendar Picker: Too wide in Japanese locale
Summary: Calendar Picker: Too wide in Japanese locale
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on: 84826
Blocks: 53961
  Show dependency treegraph
 
Reported: 2012-05-01 18:02 PDT by Kent Tamura
Modified: 2012-05-01 20:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.05 KB, patch)
2012-05-01 18:16 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch 2 (3.07 KB, patch)
2012-05-01 18:29 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-05-01 18:02:56 PDT
A calendar picker is too wide in Japanese locale because YearMonthController.attachTo() tests "275760年(平成273772年) N月" to decide the width.
Comment 1 Kent Tamura 2012-05-01 18:16:06 PDT
Created attachment 139719 [details]
Patch
Comment 2 Kentaro Hara 2012-05-01 18:25:15 PDT
Comment on attachment 139719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139719&action=review

Waiting for keishi-san's review.

> Source/WebCore/Resources/calendarPicker.js:139
> +    if (year > 2087)

Nit: You might want to use imperialEraLimit.
Comment 3 Kent Tamura 2012-05-01 18:26:32 PDT
Comment on attachment 139719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139719&action=review

>> Source/WebCore/Resources/calendarPicker.js:139
>> +    if (year > 2087)
> 
> Nit: You might want to use imperialEraLimit.

oh, you're right.
Comment 4 Kent Tamura 2012-05-01 18:29:52 PDT
Created attachment 139720 [details]
Patch 2
Comment 5 Keishi Hattori 2012-05-01 19:19:56 PDT
Comment on attachment 139720 [details]
Patch 2

ok looks good
Comment 6 WebKit Review Bot 2012-05-01 20:00:46 PDT
Comment on attachment 139720 [details]
Patch 2

Clearing flags on attachment: 139720

Committed r115783: <http://trac.webkit.org/changeset/115783>
Comment 7 WebKit Review Bot 2012-05-01 20:00:50 PDT
All reviewed patches have been landed.  Closing bug.