Bug 84813 – Layout Test css3/filters/custom/custom-filter-shader-cache.html is failing

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Hin-Chung Lam]

The following layout test is failing on chromium:

css3/filters/custom/custom-filter-shader-cache.html
css3/filters/custom/effect-custom-combined-missing.html
css3/filters/custom/effect-custom-parameters.html
css3/filters/custom/effect-custom.html

Probable cause:

http://trac.webkit.org/changeset/115123 updates code that does this, possibly a rebaseline is needed.

[Hin-Chung Lam]

Created attachment 138711 [details]
Patch

[Hin-Chung Lam]

I left out css3/filters/custom/effect-custom-parameters.html because the actual results are different in chromium-mac and chromium-linux.

[Alexandru Chiculita]

(In reply to comment #2)
> I left out css3/filters/custom/effect-custom-parameters.html because the actual results are different in chromium-mac and chromium-linux.

This one may be related to https://bugs.webkit.org/show_bug.cgi?id=84067 . I've just seen the bug today.

Is there an easy way to generate expected results on all chromium platforms? CSS Shaders in general render slightly different from one platform to the other or even one GPU to the other.

[Hin-Chung Lam]

On Linux you can run Tools/Scripts/webkit-patch garden-o-matic and click Rebaseline without the suppression in test_expectations.txt. It will will show you expected, actual results and differences.

[Alexandru Chiculita]

(In reply to comment #3)
> (In reply to comment #2)
> > I left out css3/filters/custom/effect-custom-parameters.html because the actual results are different in chromium-mac and chromium-linux.
> 
> This one may be related to https://bugs.webkit.org/show_bug.cgi?id=84067 . I've just seen the bug today.
> 
> Is there an easy way to generate expected results on all chromium platforms? CSS Shaders in general render slightly different from one platform to the other or even one GPU to the other.

I've just run css3/filters/custom/effect-custom-parameters.html on Chromium on Mac and the difference is only about the color. I think we are ok with that result. Can you please include it in your patch?

[Hin-Chung Lam]

Will do.(In reply to comment #5)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > I left out css3/filters/custom/effect-custom-parameters.html because the actual results are different in chromium-mac and chromium-linux.
> > 
> > This one may be related to https://bugs.webkit.org/show_bug.cgi?id=84067 . I've just seen the bug today.
> > 
> > Is there an easy way to generate expected results on all chromium platforms? CSS Shaders in general render slightly different from one platform to the other or even one GPU to the other.
> 
> I've just run css3/filters/custom/effect-custom-parameters.html on Chromium on Mac and the difference is only about the color. I think we are ok with that result. Can you please include it in your patch?

Wiill do.

[Alexandru Chiculita]

It seems there's a duplicate of that. https://bugs.webkit.org/show_bug.cgi?id=82372

[Tony Chang]

@hclam - did this patch land or did you want a review?

[Tony Chang]

Did chromium end up enabling CSS Filters?  Should we rebaseline the tests in css3/filters/custom?

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Ffilters%2Fcustom

TestExpectations currently has:

// CSS custom() filters are not currently supported
BUGWK71392 WIN : css3/filters/custom = IMAGE IMAGE+TEXT PASS

We should remove that, no?

[Hin-Chung Lam]

This review was sitting for a long time let me go over this again.

(In reply to comment #9)
> Did chromium end up enabling CSS Filters?  Should we rebaseline the tests in css3/filters/custom?
> 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Ffilters%2Fcustom
> 
> TestExpectations currently has:
> 
> // CSS custom() filters are not currently supported
> BUGWK71392 WIN : css3/filters/custom = IMAGE IMAGE+TEXT PASS
> 
> We should remove that, no?

[Hin-Chung Lam]

The patch I uploaded was a gardening effort. 

Closing this bug as this is a duplicate of 82372 introduced by  Chiculita's patch.

*** This bug has been marked as a duplicate of bug 82372 ***

[Stephen White]

(In reply to comment #9)
> Did chromium end up enabling CSS Filters?  Should we rebaseline the tests in css3/filters/custom?

Just to be clear:  CSS Filters are enabled in Chrome, but the custom() GLSL ones (aka CSS Shaders) are not, until the security issues are resolved.

DumpRenderTree has everything enabled, however, so we should be able to rebaseline the tests.

> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Ffilters%2Fcustom
> 
> TestExpectations currently has:
> 
> // CSS custom() filters are not currently supported
> BUGWK71392 WIN : css3/filters/custom = IMAGE IMAGE+TEXT PASS
> 
> We should remove that, no?

[Stephen White]

(In reply to comment #3)
> (In reply to comment #2)
> > I left out css3/filters/custom/effect-custom-parameters.html because the actual results are different in chromium-mac and chromium-linux.
> 
> This one may be related to https://bugs.webkit.org/show_bug.cgi?id=84067 . I've just seen the bug today.
> 
> Is there an easy way to generate expected results on all chromium platforms? CSS Shaders in general render slightly different from one platform to the other or even one GPU to the other.

BTW, Chromium's DumpRenderTree runs GPU tests using the Mesa software renderer, so its results should be independent of the GPU installed on the machine.