WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
82372
[chromium] Rebaseline css3/filters/custom tests
https://bugs.webkit.org/show_bug.cgi?id=82372
Summary
[chromium] Rebaseline css3/filters/custom tests
Dirk Pranke
Reported
2012-03-27 13:12:02 PDT
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Ffilters%2Fcustom%2Feffect-custom-parameters.html
I'm not sure who the best person to look into this is, or if there's anything much we can do about it (or if they're just rounding errors).
Attachments
Patch
(216.48 KB, patch)
2012-07-20 10:57 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Patch
(216.48 KB, patch)
2012-07-20 11:01 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Patch for landing
(216.50 KB, patch)
2012-07-20 11:55 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Patch for landing
(216.52 KB, patch)
2012-07-20 12:03 PDT
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Tony Chang
Comment 1
2012-03-27 13:15:13 PDT
We can add a Linux 32 baseline. It looks like a rounding difference. I guess we could just mark LINUX DEBUG as IMAGE.
Alexandru Chiculita
Comment 2
2012-04-25 13:39:09 PDT
I think this is related to
https://bugs.webkit.org/show_bug.cgi?id=84813
. The color difference is expected from one GPU to the other.
Hin-Chung Lam
Comment 3
2012-07-19 16:06:37 PDT
***
Bug 84813
has been marked as a duplicate of this bug. ***
Tony Chang
Comment 4
2012-07-20 10:57:03 PDT
Created
attachment 153540
[details]
Patch
Tony Chang
Comment 5
2012-07-20 10:57:57 PDT
Stephen, do these look OK to you?
Tony Chang
Comment 6
2012-07-20 10:58:39 PDT
Comment on
attachment 153540
[details]
Patch Hah, that diff is not so useful. Let me try again.
Tony Chang
Comment 7
2012-07-20 11:01:20 PDT
Created
attachment 153542
[details]
Patch
Tony Chang
Comment 8
2012-07-20 11:02:34 PDT
Oh, I bet this is related to the bugzilla server upgrade. I'll file a new bug for it.
Stephen White
Comment 9
2012-07-20 11:11:18 PDT
(In reply to
comment #5
)
> Stephen, do these look OK to you?
Alex would know better if the pixel results are correct (once we can see them). The TestExpectations changes look fine.
Alexandru Chiculita
Comment 10
2012-07-20 11:26:09 PDT
(In reply to
comment #9
)
> (In reply to
comment #5
) > > Stephen, do these look OK to you? > > Alex would know better if the pixel results are correct (once we can see them). The TestExpectations changes look fine.
Yes, I could check them once I get to see them. I will try to apply the patch on my machine instead.
Tony Chang
Comment 11
2012-07-20 11:42:41 PDT
(In reply to
comment #10
)
> (In reply to
comment #9
) > > (In reply to
comment #5
) > > > Stephen, do these look OK to you? > > > > Alex would know better if the pixel results are correct (once we can see them). The TestExpectations changes look fine. > > Yes, I could check them once I get to see them. I will try to apply the patch on my machine instead.
It should be working now. You may have to press reload on the Review Patch link.
Alexandru Chiculita
Comment 12
2012-07-20 11:48:03 PDT
(In reply to
comment #11
)
> It should be working now. You may have to press reload on the Review Patch link.
It doesn't work yet for me, but I've applied it on my machine. The images look fine. It seems like color correction is just a little bit different, but the functionality that those tests are asserting is working correctly.
Tony Chang
Comment 13
2012-07-20 11:55:13 PDT
Created
attachment 153552
[details]
Patch for landing
WebKit Review Bot
Comment 14
2012-07-20 11:58:04 PDT
Comment on
attachment 153552
[details]
Patch for landing Rejecting
attachment 153552
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/13307330
Tony Chang
Comment 15
2012-07-20 12:03:50 PDT
Created
attachment 153555
[details]
Patch for landing
WebKit Review Bot
Comment 16
2012-07-20 13:07:37 PDT
Comment on
attachment 153555
[details]
Patch for landing Clearing flags on attachment: 153555 Committed
r123252
: <
http://trac.webkit.org/changeset/123252
>
WebKit Review Bot
Comment 17
2012-07-20 13:07:41 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug