WinCairo build fails on WebKit2 due to dependency to CG. Looks like code changes added as part of Bug#55956 broken in latest code. Some of the error log below, 10>..\WebProcess\WebPage\WebPage.cpp(2896) : error C2065: 'CGDataConsumerRef' : undeclared identifier 10>..\WebProcess\WebPage\WebPage.cpp(2896) : error C3861: 'CGDataConsumerCreateWithCFData': identifier not found 10>..\WebProcess\WebPage\WebPage.cpp(2896) : error C2514: 'WTF::RetainPtr' : class has no constructors 10> C:\cygwin\home\lejin.pj\WebKit\WebKitBuild\Debug_Cairo_CFLite\Include\private\wtf/RetainPtr.h(55) : see declaration of 'WTF::RetainPtr' 10>..\WebProcess\WebPage\WebPage.cpp(2898) : error C2065: 'CGRect' : undeclared identifier 10>..\WebProcess\WebPage\WebPage.cpp(2898) : error C2146: syntax error : missing ';' before identifier 'mediaBox' 10>..\WebProcess\WebPage\WebPage.cpp(2898) : error C2065: 'mediaBox' : undeclared identifier 10>..\WebProcess\WebPage\WebPage.cpp(2898) : error C3861: 'CGRectMake': identifier not found 10>..\WebProcess\WebPage\WebPage.cpp(2899) : error C2065: 'CGContextRef' : undeclared identifier CG related code need to be put under CG macro.
Created attachment 139002 [details] Fixes build on Cairo Fixes build on Cairo.
CCing Brent.
Comment on attachment 139002 [details] Fixes build on Cairo r- as the Changelog is missing. Can you explain the change in debug_wincairo.vsprops ?
These changes look good. The WK2 stuff doesn't run currently, so the stunned out sections re fine. Removing the DEBUG_ALL from the property sheet is reasonable, as I don't usually want to build/run with debug support libraries. Ideally we would have a "Debug All" target (just like Apple does) to allow such a build.
There is no WebKit2 on Windows long time ago.