Bug 84561 - WinCairo build fails on WebKit2
Summary: WinCairo build fails on WebKit2
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-22 22:18 PDT by Jose Lejin PJ
Modified: 2013-11-07 08:21 PST (History)
3 users (show)

See Also:


Attachments
Fixes build on Cairo (2.89 KB, patch)
2012-04-26 07:53 PDT, Eric Fortin
laszlo.gombos: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Lejin PJ 2012-04-22 22:18:09 PDT
WinCairo build fails on WebKit2 due to dependency to CG.
Looks like code changes added as part of Bug#55956 broken in latest code.

Some of the error log below,

10>..\WebProcess\WebPage\WebPage.cpp(2896) : error C2065: 'CGDataConsumerRef' : undeclared identifier
10>..\WebProcess\WebPage\WebPage.cpp(2896) : error C3861: 'CGDataConsumerCreateWithCFData': identifier not found
10>..\WebProcess\WebPage\WebPage.cpp(2896) : error C2514: 'WTF::RetainPtr' : class has no constructors
10>        C:\cygwin\home\lejin.pj\WebKit\WebKitBuild\Debug_Cairo_CFLite\Include\private\wtf/RetainPtr.h(55) : see declaration of 'WTF::RetainPtr'
10>..\WebProcess\WebPage\WebPage.cpp(2898) : error C2065: 'CGRect' : undeclared identifier
10>..\WebProcess\WebPage\WebPage.cpp(2898) : error C2146: syntax error : missing ';' before identifier 'mediaBox'
10>..\WebProcess\WebPage\WebPage.cpp(2898) : error C2065: 'mediaBox' : undeclared identifier
10>..\WebProcess\WebPage\WebPage.cpp(2898) : error C3861: 'CGRectMake': identifier not found
10>..\WebProcess\WebPage\WebPage.cpp(2899) : error C2065: 'CGContextRef' : undeclared identifier

CG related code need to be put under CG macro.
Comment 1 Eric Fortin 2012-04-26 07:53:19 PDT
Created attachment 139002 [details]
Fixes build on Cairo

Fixes build on Cairo.
Comment 2 Laszlo Gombos 2012-08-05 17:39:36 PDT
CCing Brent.
Comment 3 Laszlo Gombos 2012-08-05 17:40:58 PDT
Comment on attachment 139002 [details]
Fixes build on Cairo

r- as the Changelog is missing.

Can you explain the change in debug_wincairo.vsprops ?
Comment 4 Brent Fulgham 2012-08-05 18:11:51 PDT
These changes look good. The WK2 stuff doesn't run currently, so the stunned out sections re fine.

Removing the DEBUG_ALL  from the property sheet is reasonable, as I don't usually want to build/run with debug support libraries. Ideally we would have a "Debug All" target (just like Apple does) to allow such a build.
Comment 5 Csaba Osztrogonác 2013-11-07 08:21:23 PST
There is no WebKit2 on Windows long time ago.