Bug 55956 - WebKit2 Changes to correct WinCairo port build
Summary: WebKit2 Changes to correct WinCairo port build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-08 11:53 PST by Brent Fulgham
Modified: 2011-03-08 15:36 PST (History)
1 user (show)

See Also:

Attachments
Build corrections for WinCairo (15.06 KB, patch)
2011-03-08 11:57 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Get rid of tabs! (15.17 KB, patch)
2011-03-08 12:13 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Correct <stdint.h> include ordering (15.17 KB, patch)
2011-03-08 12:19 PST, Brent Fulgham 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2011-03-08 11:53:05 PST 
The recent changes to the WebKit2 rendering logic do not build properly under WinCairo.  This issue collects the changes I made to get things building again.
Comment 1 Brent Fulgham 2011-03-08 11:57:55 PST 
Created attachment 85075 [details]
Build corrections for WinCairo
Comment 2 WebKit Review Bot 2011-03-08 12:00:40 PST 
Attachment 85075 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/ChangeLog:20:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/ChangeLog:25:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/ChangeLog:27:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit2/UIProcess/DrawingAreaProxy.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/win/WebView.cpp:1122:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 7 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2011-03-08 12:13:06 PST 
Created attachment 85076 [details]
Get rid of tabs!
Comment 4 WebKit Review Bot 2011-03-08 12:15:36 PST 
Attachment 85076 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/DrawingAreaProxy.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brent Fulgham 2011-03-08 12:19:32 PST 
Created attachment 85078 [details]
Correct <stdint.h> include ordering
Comment 6 Brent Fulgham 2011-03-08 15:36:46 PST 
Landed in  http://trac.webkit.org/changeset/80596.